From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] drm/exynos: Allow module to be autoloaded
Date: Mon, 28 Jul 2014 10:30:46 +0200 [thread overview]
Message-ID: <1406536246.15871.6.camel@dusk> (raw)
In-Reply-To: <1405925419.7527.17.camel@dusk>
[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]
Hey Inki,
On Mon, 2014-07-21 at 08:50 +0200, Sjoerd Simons wrote:
> Hey Inki,
>
> On Mon, 2014-07-21 at 12:02 +0900, Inki Dae wrote:
> > On 2014년 07월 19일 05:36, Sjoerd Simons wrote:
> > > The exynos DRM module currently is not automatically loaded when build as a
> > > module. This is due to the simple fact that it doesn't have any
> > > MODULE_DEVICE_TABLE entries whatsoever... Most of these were removed previously
> > > as it wasn't possible at the time to have multiple calls to MODULE_DEVICE_TABLE
> > > in one module, however commit 21bdd17b21b45ea solved that.
> > >
> > > The first two patches revert the previous removals of MODULE_DEVICE_TABLE
> > > calls, while the last one adds calls for the remaining OF match tables without a
> > > MODULE_DEVICE_TABLE call.
>
> > Exynos drm follows single-driver model. So each usb driver of Exynos drm
> > wouldn't need its own MODULE_DEVICE_TABLE.
>
> Strictly speaking you're right, for module autoloading to work the
> module just needs to have one that matches. So in principle all other
> entries are redundant.
>
> However for exynos drm there does not seem to be one main device which
> is guaranteed to always be present which can be used to key the module
> autoloading of. So you still need seperate MODULE_DEVICE_TABLE entries
> for all the various subdrivers to ensure autoloading actually happens,
> especially since the various subdrivers can be seperately enabled
> at build time.
Been about a week since this last mail. If you have any suggestions on a
better approach or on how to move this forward, i'd be very grateful to
hear as i think i've addressed your original comment on the set in the
previous reply?
--
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]
next prev parent reply other threads:[~2014-07-28 8:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 20:36 [PATCH 0/3] drm/exynos: Allow module to be autoloaded Sjoerd Simons
2014-07-18 20:36 ` [PATCH 1/3] Revert "drm/exynos: fix module build error" Sjoerd Simons
2014-07-18 20:36 ` [PATCH 2/3] Revert "drm/exynos: remove MODULE_DEVICE_TABLE definitions" Sjoerd Simons
2014-07-18 20:36 ` [PATCH 3/3] drm/exynos: Add MODULE_DEVICE_TABLE entries for various components Sjoerd Simons
2014-07-21 3:02 ` [PATCH 0/3] drm/exynos: Allow module to be autoloaded Inki Dae
2014-07-21 6:50 ` Sjoerd Simons
2014-07-28 8:30 ` Sjoerd Simons [this message]
2014-07-28 14:17 ` Inki Dae
2014-07-28 14:45 ` Sjoerd Simons
2014-07-29 5:38 ` Inki Dae
2014-07-29 8:05 ` Sjoerd Simons
2014-07-29 11:59 ` Andreas Färber
2014-07-29 12:29 ` Inki Dae
2014-07-29 13:43 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406536246.15871.6.camel@dusk \
--to=sjoerd.simons@collabora.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.