Re: [PATCH 0/3] drm/exynos: Allow module to be autoloaded

[Inki Dae <inki.dae@samsung.com>]

On 2014년 07월 28일 17:30, Sjoerd Simons wrote:
> Hey Inki,
> 
> On Mon, 2014-07-21 at 08:50 +0200, Sjoerd Simons wrote:
>> Hey Inki,
>>
>> On Mon, 2014-07-21 at 12:02 +0900, Inki Dae wrote:
>>> On 2014년 07월 19일 05:36, Sjoerd Simons wrote:
>>>> The exynos DRM module currently is not automatically loaded when build as a
>>>> module. This is due to the simple fact that it doesn't have any
>>>> MODULE_DEVICE_TABLE entries whatsoever... Most of these were removed previously
>>>> as it wasn't possible at the time to have multiple calls to MODULE_DEVICE_TABLE
>>>> in one module, however commit 21bdd17b21b45ea solved that.
>>>>
>>>> The first two patches revert the previous removals of MODULE_DEVICE_TABLE
>>>> calls, while the last one adds calls for the remaining OF match tables without a
>>>> MODULE_DEVICE_TABLE call.
>>
>>> Exynos drm follows single-driver model. So each usb driver of Exynos drm
>>> wouldn't need its own MODULE_DEVICE_TABLE.
>>
>> Strictly speaking you're right, for module autoloading to work the
>> module just needs to have one that matches. So in principle all other
>> entries are redundant.
>>
>> However for exynos drm there does not seem to be one main device which
>> is guaranteed to always be present which can be used to key the module
>> autoloading of. So you still need seperate MODULE_DEVICE_TABLE entries
>> for all the various subdrivers to ensure autoloading actually happens,
>> especially since the various subdrivers can be seperately enabled
>> at build time. 
> 
> Been about a week since this last mail. If you have any suggestions on a
> better approach or on how to move this forward, i'd be very grateful to
> hear as i think i've addressed your original comment on the set in the
> previous reply?

Sorry for late,

I don't see why Exynos drm driver should be auto-loaded module. I think
all devices covered by Exynos drm framework are not hot-plugged. Maybe
there is my missing point. So can you explain why Exynos drm driver
should be auto-loaded module?

Thanks,
Inki Dae

>