From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>,
Michael Ellerman <michaele@au1.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@redhat.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Cody P Schafer <dev@codyps.com>,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Cody P Schafer <cody@linux.vnet.ibm.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: [PATCH 04/18] perf tools: Annotate PMU related list_head members with type info
Date: Fri, 15 Aug 2014 13:49:49 -0300 [thread overview]
Message-ID: <1408121403-11919-5-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1408121403-11919-1-git-send-email-acme@kernel.org>
From: Cody P Schafer <dev@codyps.com>
So that we can more readily understand in which list heads structs are
stored into.
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Cody P Schafer <dev@codyps.com>
Cc: Haren Myneni <hbabu@us.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Michael Ellerman <michaele@au1.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1408087583-32239-6-git-send-email-sukadev@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/pmu.c | 4 ++--
tools/perf/util/pmu.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 7a811eb61f75..9bf582750561 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -14,8 +14,8 @@
struct perf_pmu_alias {
char *name;
- struct list_head terms;
- struct list_head list;
+ struct list_head terms; /* HEAD struct parse_events_term -> list */
+ struct list_head list; /* ELEM */
char unit[UNIT_MAX_LEN+1];
double scale;
};
diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
index c14a543ce1f3..1c1e2eecbe1f 100644
--- a/tools/perf/util/pmu.h
+++ b/tools/perf/util/pmu.h
@@ -17,9 +17,9 @@ struct perf_pmu {
char *name;
__u32 type;
struct cpu_map *cpus;
- struct list_head format;
- struct list_head aliases;
- struct list_head list;
+ struct list_head format; /* HEAD struct perf_pmu_format -> list */
+ struct list_head aliases; /* HEAD struct perf_pmu_alias -> list */
+ struct list_head list; /* ELEM */
};
struct perf_pmu *perf_pmu__find(const char *name);
--
1.9.3
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Cody P Schafer <dev@codyps.com>,
Cody P Schafer <cody@linux.vnet.ibm.com>,
Andi Kleen <ak@linux.intel.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Haren Myneni <hbabu@us.ibm.com>, Jiri Olsa <jolsa@redhat.com>,
Michael Ellerman <michaele@au1.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
linuxppc-dev@lists.ozlabs.org,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 04/18] perf tools: Annotate PMU related list_head members with type info
Date: Fri, 15 Aug 2014 13:49:49 -0300 [thread overview]
Message-ID: <1408121403-11919-5-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1408121403-11919-1-git-send-email-acme@kernel.org>
From: Cody P Schafer <dev@codyps.com>
So that we can more readily understand in which list heads structs are
stored into.
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Cody P Schafer <dev@codyps.com>
Cc: Haren Myneni <hbabu@us.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Michael Ellerman <michaele@au1.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1408087583-32239-6-git-send-email-sukadev@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/pmu.c | 4 ++--
tools/perf/util/pmu.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 7a811eb61f75..9bf582750561 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -14,8 +14,8 @@
struct perf_pmu_alias {
char *name;
- struct list_head terms;
- struct list_head list;
+ struct list_head terms; /* HEAD struct parse_events_term -> list */
+ struct list_head list; /* ELEM */
char unit[UNIT_MAX_LEN+1];
double scale;
};
diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
index c14a543ce1f3..1c1e2eecbe1f 100644
--- a/tools/perf/util/pmu.h
+++ b/tools/perf/util/pmu.h
@@ -17,9 +17,9 @@ struct perf_pmu {
char *name;
__u32 type;
struct cpu_map *cpus;
- struct list_head format;
- struct list_head aliases;
- struct list_head list;
+ struct list_head format; /* HEAD struct perf_pmu_format -> list */
+ struct list_head aliases; /* HEAD struct perf_pmu_alias -> list */
+ struct list_head list; /* ELEM */
};
struct perf_pmu *perf_pmu__find(const char *name);
--
1.9.3
next prev parent reply other threads:[~2014-08-15 16:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 01/18] perf probe: Warn user to rebuild target with debuginfo Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 02/18] perf annotate: Don't truncate Intel style addresses Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 03/18] perf tools: Add arm64 triplets Arnaldo Carvalho de Melo
2014-08-15 16:49 ` Arnaldo Carvalho de Melo [this message]
2014-08-15 16:49 ` [PATCH 04/18] perf tools: Annotate PMU related list_head members with type info Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 05/18] perf report: Relax -g option parsing not to limit the option order Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 06/18] perf probe: Don't use strerror if strlist__add failed Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 07/18] perf: Use strerror_r instead of strerror Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 08/18] perf probe: Make error messages thread-safe Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 09/18] perf util: Replace strerror with strerror_r for thread-safety Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 10/18] perf top: Use strerror_r instead of strerror Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 11/18] perf trace: " Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 12/18] perf record: " Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 13/18] perf test: " Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 14/18] perf sched: " Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 15/18] perf buildid-cache: " Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 16/18] perf kvm: " Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 17/18] perf help: " Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 18/18] perf stat: " Arnaldo Carvalho de Melo
2014-08-18 8:18 ` [GIT PULL 00/18] perf/core improvements and fixes Ingo Molnar
2014-08-18 8:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408121403-11919-5-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=cody@linux.vnet.ibm.com \
--cc=dev@codyps.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.