From: Ian Campbell <ian.campbell@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] tools/libxc: Set max_elem to zero in xc_lockprof_query_number()
Date: Tue, 26 Aug 2014 22:13:13 +0100 [thread overview]
Message-ID: <1409087593.28009.49.camel@citrix.com> (raw)
In-Reply-To: <1407948038-13998-1-git-send-email-boris.ostrovsky@oracle.com>
On Wed, 2014-08-13 at 12:40 -0400, Boris Ostrovsky wrote:
> If max_elem is not zero then hypervisor's spinlock_profile_ucopy_elem()
> will attempt to copy profile data into user's data buffer. Since this
> buffer is explicitly set to (the equivalent of) NULL the copy will fail,
> causing xenlockprof to fail as well.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
I would have expected DECLARE_SYSCTL to zero the struct, but anyway:
Acked + applied, thanks (and sorry for the delay).
prev parent reply other threads:[~2014-08-26 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 16:40 [PATCH] tools/libxc: Set max_elem to zero in xc_lockprof_query_number() Boris Ostrovsky
2014-08-26 21:13 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409087593.28009.49.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.