* [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove
@ 2014-08-28 9:54 Axel Lin
2014-08-28 9:55 ` [PATCH 2/2] ASoC: cs42l56: Remove unneeded regulator_bulk_free call in cs42l56_remove Axel Lin
2014-08-28 18:07 ` [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2014-08-28 9:54 UTC (permalink / raw)
To: Mark Brown
Cc: Brian Austin, alsa-devel@alsa-project.org, Liam Girdwood,
Paul Handrigan
The regulator_bulk_free() call is not required because current code is using
devm_regulator_bulk_get().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/cs35l32.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c
index 380c212..718569f 100644
--- a/sound/soc/codecs/cs35l32.c
+++ b/sound/soc/codecs/cs35l32.c
@@ -548,8 +548,6 @@ static int cs35l32_i2c_remove(struct i2c_client *i2c_client)
if (cs35l32->reset_gpio)
gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
- regulator_bulk_free(ARRAY_SIZE(cs35l32->supplies), cs35l32->supplies);
-
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ASoC: cs42l56: Remove unneeded regulator_bulk_free call in cs42l56_remove
2014-08-28 9:54 [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove Axel Lin
@ 2014-08-28 9:55 ` Axel Lin
2014-08-28 14:08 ` Brian Austin
2014-08-28 18:07 ` [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2014-08-28 9:55 UTC (permalink / raw)
To: Mark Brown
Cc: Brian Austin, alsa-devel@alsa-project.org, Liam Girdwood,
Paul Handrigan
The regulator_bulk_free() call is not required because current code is using
devm_regulator_bulk_get().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/cs42l56.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c
index c766a5a..5a2d732 100644
--- a/sound/soc/codecs/cs42l56.c
+++ b/sound/soc/codecs/cs42l56.c
@@ -1175,11 +1175,8 @@ static int cs42l56_probe(struct snd_soc_codec *codec)
static int cs42l56_remove(struct snd_soc_codec *codec)
{
- struct cs42l56_private *cs42l56 = snd_soc_codec_get_drvdata(codec);
-
cs42l56_free_beep(codec);
cs42l56_set_bias_level(codec, SND_SOC_BIAS_OFF);
- regulator_bulk_free(ARRAY_SIZE(cs42l56->supplies), cs42l56->supplies);
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] ASoC: cs42l56: Remove unneeded regulator_bulk_free call in cs42l56_remove
2014-08-28 9:55 ` [PATCH 2/2] ASoC: cs42l56: Remove unneeded regulator_bulk_free call in cs42l56_remove Axel Lin
@ 2014-08-28 14:08 ` Brian Austin
0 siblings, 0 replies; 4+ messages in thread
From: Brian Austin @ 2014-08-28 14:08 UTC (permalink / raw)
To: Axel Lin
Cc: alsa-devel@alsa-project.org, Brian Austin, Mark Brown,
Liam Girdwood, Paul Handrigan
On Thu, 28 Aug 2014, Axel Lin wrote:
> The regulator_bulk_free() call is not required because current code is using
> devm_regulator_bulk_get().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> sound/soc/codecs/cs42l56.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c
> index c766a5a..5a2d732 100644
> --- a/sound/soc/codecs/cs42l56.c
> +++ b/sound/soc/codecs/cs42l56.c
> @@ -1175,11 +1175,8 @@ static int cs42l56_probe(struct snd_soc_codec *codec)
>
> static int cs42l56_remove(struct snd_soc_codec *codec)
> {
> - struct cs42l56_private *cs42l56 = snd_soc_codec_get_drvdata(codec);
> -
> cs42l56_free_beep(codec);
> cs42l56_set_bias_level(codec, SND_SOC_BIAS_OFF);
> - regulator_bulk_free(ARRAY_SIZE(cs42l56->supplies), cs42l56->supplies);
>
> return 0;
> }
Thanks Axel,
For the series..
Acked-by: Brian Austin <brian.austin@cirrus.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove
2014-08-28 9:54 [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove Axel Lin
2014-08-28 9:55 ` [PATCH 2/2] ASoC: cs42l56: Remove unneeded regulator_bulk_free call in cs42l56_remove Axel Lin
@ 2014-08-28 18:07 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-08-28 18:07 UTC (permalink / raw)
To: Axel Lin
Cc: Brian Austin, alsa-devel@alsa-project.org, Liam Girdwood,
Paul Handrigan
[-- Attachment #1.1: Type: text/plain, Size: 189 bytes --]
On Thu, Aug 28, 2014 at 05:54:38PM +0800, Axel Lin wrote:
> The regulator_bulk_free() call is not required because current code is using
> devm_regulator_bulk_get().
Applied both, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-28 18:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-28 9:54 [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove Axel Lin
2014-08-28 9:55 ` [PATCH 2/2] ASoC: cs42l56: Remove unneeded regulator_bulk_free call in cs42l56_remove Axel Lin
2014-08-28 14:08 ` Brian Austin
2014-08-28 18:07 ` [PATCH 1/2] ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.