From: Alex Gartrell <agartrell@fb.com>
To: horms@verge.net.au
Cc: ja@ssi.bg, lvs-devel@vger.kernel.org, kernel-team@fb.com,
Alex Gartrell <agartrell@fb.com>
Subject: [PATCH ipvs,v4 03/20] ipvs: Pass destination address family to ip_vs_trash_get_dest
Date: Fri, 29 Aug 2014 01:38:52 -0700 [thread overview]
Message-ID: <1409301549-5284-4-git-send-email-agartrell@fb.com> (raw)
In-Reply-To: <1409301549-5284-1-git-send-email-agartrell@fb.com>
Part of a series of diffs to tease out destination family from virtual
family. This diff just adds a parameter to ip_vs_trash_get and then uses
it for comparison rather than svc->af.
Signed-off-by: Alex Gartrell <agartrell@fb.com>
---
net/netfilter/ipvs/ip_vs_ctl.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index a8589df..33d04ee 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -657,8 +657,8 @@ static void __ip_vs_dst_cache_reset(struct ip_vs_dest *dest)
* scheduling.
*/
static struct ip_vs_dest *
-ip_vs_trash_get_dest(struct ip_vs_service *svc, const union nf_inet_addr *daddr,
- __be16 dport)
+ip_vs_trash_get_dest(struct ip_vs_service *svc, int dest_af,
+ const union nf_inet_addr *daddr, __be16 dport)
{
struct ip_vs_dest *dest;
struct netns_ipvs *ipvs = net_ipvs(svc->net);
@@ -671,11 +671,11 @@ ip_vs_trash_get_dest(struct ip_vs_service *svc, const union nf_inet_addr *daddr,
IP_VS_DBG_BUF(3, "Destination %u/%s:%u still in trash, "
"dest->refcnt=%d\n",
dest->vfwmark,
- IP_VS_DBG_ADDR(svc->af, &dest->addr),
+ IP_VS_DBG_ADDR(dest->af, &dest->addr),
ntohs(dest->port),
atomic_read(&dest->refcnt));
- if (dest->af == svc->af &&
- ip_vs_addr_equal(svc->af, &dest->addr, daddr) &&
+ if (dest->af == dest_af &&
+ ip_vs_addr_equal(dest_af, &dest->addr, daddr) &&
dest->port == dport &&
dest->vfwmark == svc->fwmark &&
dest->protocol == svc->protocol &&
@@ -950,7 +950,7 @@ ip_vs_add_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest)
* Check if the dest already exists in the trash and
* is from the same service
*/
- dest = ip_vs_trash_get_dest(svc, &daddr, dport);
+ dest = ip_vs_trash_get_dest(svc, udest->af, &daddr, dport);
if (dest != NULL) {
IP_VS_DBG_BUF(3, "Get destination %s:%u from trash, "
--
1.8.1
next prev parent reply other threads:[~2014-08-29 8:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 8:38 [PATCH ipvs,v4 00/20] Support v6 real servers in v4 pools and vice versa Alex Gartrell
2014-08-29 8:38 ` [PATCH ipvs,v4 01/20] ipvs: Add destination address family to netlink interface Alex Gartrell
2014-08-29 8:38 ` [PATCH ipvs,v4 02/20] ipvs: Supply destination addr family to ip_vs_{lookup_dest,find_dest} Alex Gartrell
2014-08-29 8:38 ` Alex Gartrell [this message]
2014-08-29 8:38 ` [PATCH ipvs,v4 04/20] ipvs: Supply destination address family to ip_vs_conn_new Alex Gartrell
2014-08-29 8:38 ` [PATCH ipvs,v4 05/20] ipvs: prevent mixing heterogeneous pools and synchronization Alex Gartrell
2014-08-29 8:38 ` [PATCH ipvs,v4 06/20] ipvs: Pull out crosses_local_route_boundary logic Alex Gartrell
2014-08-29 8:38 ` [PATCH ipvs,v4 07/20] ipvs: Pull out update_pmtu code Alex Gartrell
2014-08-29 8:38 ` [PATCH ipvs,v4 08/20] ipvs: Add generic ensure_mtu_is_adequate to handle mixed pools Alex Gartrell
2014-08-29 8:38 ` [PATCH ipvs,v4 09/20] ipvs: support ipv4 in ipv6 and ipv6 in ipv4 tunnel forwarding Alex Gartrell
2014-08-29 8:38 ` [PATCH ipvs,v4 10/20] ipvs: address family of LBLC entry depends on svc family Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 11/20] ipvs: address family of LBLCR " Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 12/20] ipvs: use correct address family in DH logs Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 13/20] ipvs: use correct address family in LC logs Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 14/20] ipvs: use correct address family in NQ logs Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 15/20] ipvs: use correct address family in RR logs Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 16/20] ipvs: use correct address family in SED logs Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 17/20] ipvs: use correct address family in SH logs Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 18/20] ipvs: use correct address family in WLC logs Alex Gartrell
2014-08-29 8:39 ` [PATCH ipvs,v4 19/20] ipvs: use the new dest addr family field Alex Gartrell
2014-08-29 10:32 ` Julian Anastasov
2014-08-29 21:19 ` Alex Gartrell
2014-08-30 8:35 ` Julian Anastasov
2014-09-01 1:17 ` Simon Horman
2014-09-09 19:41 ` Julian Anastasov
2014-09-09 23:22 ` Alex Gartrell
2014-09-10 6:05 ` Julian Anastasov
2014-08-29 8:39 ` [PATCH ipvs,v4 20/20] ipvs: Allow heterogeneous pools now that we support them Alex Gartrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409301549-5284-4-git-send-email-agartrell@fb.com \
--to=agartrell@fb.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kernel-team@fb.com \
--cc=lvs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.