Re: [PATCH ipvs,v4 19/20] ipvs: use the new dest addr family field

[Alex Gartrell <agartrell@fb.com>]

Hey Julian,

On 9/9/14 12:41 PM, Julian Anastasov wrote:
>
> 	Hello Alex,
>
> On Fri, 29 Aug 2014, Alex Gartrell wrote:
>
>> So, if I understand correctly, we'll wait until it lands in net-next and then
>> I'll submit these patches to netdev?
>
> 	I think, you can now submit the patchset, net was
> merged to net-next, so you need a fresh net-next copy.

I've picked these patches onto net-next and am going to test it now. 
Will submit the patchset shortly.

> 	Also, can you try my ipvsadm patches to check for
> possible problems in the connection listing, so that we
> can safely apply them to the ipvsadm tree.
>


All of the ipvsadm changes work as expected, but it needs an additional 
tweak:

diff --git a/ipvsadm.c b/ipvsadm.c
index d12070e..ef19091 100644
--- a/ipvsadm.c
+++ b/ipvsadm.c
@@ -1629,7 +1629,7 @@ print_service_entry(ipvs_service_entry_t *se, 
unsigned int format)
                         fprintf(stderr, "addrport_to_anyname fails\n");
                         exit(1);
                 }
-               if (!(format & FMT_RULE) && (se->af != AF_INET6))
+               if (!(format & FMT_RULE) && (e->af != AF_INET6))
                         dname[28] = '\0';

                 if (format & FMT_RULE) {

Thanks,
-- 
Alex Gartrell <agartrell@fb.com>