Re: [PATCH v1 2/4] libxc: add rt scheduler

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1971 bytes --]

On ven, 2014-09-05 at 13:17 -0400, Meng Xu wrote:
> 2014-09-05 6:34 GMT-04:00 Dario Faggioli <dario.faggioli@citrix.com>:

> > So, for instance, this file can continue being xc_rt.c, but this
> > function needs to be called xc_sched_rtds_domain_set()
> > (or .._rt_ds_domain_..)
> 
> As to the function name, if I change it to ..._rt_ds_domain_... in
> xc_rt.c file, do I need to change it in libxl and xl files? In
> addition, do I need to change the name rt_* functions in
> xen/common/sched_rt.c in the hypervisor? This seems a lot of (well
> easy) change, but we need some consensus to avoid changing it back
> later. :-P
>
I see your point, and I'm actually not so sure... Would appreciate
George's and others' view here.

IIRC, we decided for RT_DS for two reasons:
 * make it more clear what kind of real-time scheduler this is, among
   all the existing real-time schedulers
 * make it possible to add more and different RT_xxx schedulers without
   having to rename this one and/or cause confusion

I think both these arguments are valid for whatever component of the Xen
architecture we are dealing with. We decided to keep the filename
sched_rt.c (and xc_rt.c, etc), because it is at least quite likely that
these other real-time scheduling policies, if ever implemented, could
all live there.

About the function names, I would apply the same approach. Most of them,
I think they should be named after the scheduler they deal with. Some of
them may be general enough to just be called bla_rt_foo(), but it's
really hard to judge now.

However, since this also is about interfaces, I'd really appreciate
seeing what others think.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel