From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board
Date: Mon, 15 Sep 2014 16:56:06 +0200 [thread overview]
Message-ID: <1410792966.883.2.camel@AMDC1943> (raw)
In-Reply-To: <CABxcv=mYWDVwOWbvV4xy+xS5tQUrCexCT_LD7hgUO2d3FPe56w@mail.gmail.com>
On pon, 2014-09-15 at 16:36 +0200, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On Fri, Sep 12, 2014 at 2:03 PM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
> > + i2c_max77693: i2c-gpio-1 {
> > + compatible = "i2c-gpio";
> > + gpios = <&gpm2 0 0>, <&gpm2 1 0 >;
>
> Can you please include <dt-bindings/gpio/gpio.h> and use
> GPIO_ACTIVE_HIGH instead of 0 here for the type/level flags?
Sure!
>
> > + i2c-gpio,delay-us = <2>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + status = "okay";
> > +
> > + max77693@66 {
> > + compatible = "maxim,max77693";
> > + interrupt-parent = <&gpx1>;
> > + interrupts = <5 2>;
> > + reg = <0x66>;
> > +
> > + regulators {
> > + esafeout1_reg: esafeout@1 {
> > + regulator-compatible = "ESAFEOUT1";
>
> According to Documentation/devicetree/bindings/regulator/regulator.txt,
> the "regulator-compatible" DT property has been deprecated in favor of
> just using the regulator node's name.
OK
>
> > + regulator-name = "ESAFEOUT1";
> > + };
> > + esafeout2_reg: esafeout@2 {
> > + regulator-compatible = "ESAFEOUT2";
> > + regulator-name = "ESAFEOUT2";
> > + };
> > + charger_reg: charger@0 {
> > + regulator-compatible = "CHARGER";
> > + regulator-name = "CHARGER";
> > + regulator-min-microamp = <60000>;
> > + regulator-max-microamp = <2580000>;
> > + };
> > + };
> > + };
> > + };
> > +
> > mmc@12550000 {
> > num-slots = <1>;
> > supports-highspeed;
> >
>
> Once those two issues are addressed, feel free to add my
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Thank you for feedback!
Best regards,
Krzysztof
>
> Best regards,
> Javier
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board
Date: Mon, 15 Sep 2014 16:56:06 +0200 [thread overview]
Message-ID: <1410792966.883.2.camel@AMDC1943> (raw)
In-Reply-To: <CABxcv=mYWDVwOWbvV4xy+xS5tQUrCexCT_LD7hgUO2d3FPe56w@mail.gmail.com>
On pon, 2014-09-15 at 16:36 +0200, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On Fri, Sep 12, 2014 at 2:03 PM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
> > + i2c_max77693: i2c-gpio-1 {
> > + compatible = "i2c-gpio";
> > + gpios = <&gpm2 0 0>, <&gpm2 1 0 >;
>
> Can you please include <dt-bindings/gpio/gpio.h> and use
> GPIO_ACTIVE_HIGH instead of 0 here for the type/level flags?
Sure!
>
> > + i2c-gpio,delay-us = <2>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + status = "okay";
> > +
> > + max77693 at 66 {
> > + compatible = "maxim,max77693";
> > + interrupt-parent = <&gpx1>;
> > + interrupts = <5 2>;
> > + reg = <0x66>;
> > +
> > + regulators {
> > + esafeout1_reg: esafeout at 1 {
> > + regulator-compatible = "ESAFEOUT1";
>
> According to Documentation/devicetree/bindings/regulator/regulator.txt,
> the "regulator-compatible" DT property has been deprecated in favor of
> just using the regulator node's name.
OK
>
> > + regulator-name = "ESAFEOUT1";
> > + };
> > + esafeout2_reg: esafeout at 2 {
> > + regulator-compatible = "ESAFEOUT2";
> > + regulator-name = "ESAFEOUT2";
> > + };
> > + charger_reg: charger at 0 {
> > + regulator-compatible = "CHARGER";
> > + regulator-name = "CHARGER";
> > + regulator-min-microamp = <60000>;
> > + regulator-max-microamp = <2580000>;
> > + };
> > + };
> > + };
> > + };
> > +
> > mmc at 12550000 {
> > num-slots = <1>;
> > supports-highspeed;
> >
>
> Once those two issues are addressed, feel free to add my
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Thank you for feedback!
Best regards,
Krzysztof
>
> Best regards,
> Javier
next prev parent reply other threads:[~2014-09-15 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 12:03 [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board Krzysztof Kozlowski
2014-09-12 12:03 ` Krzysztof Kozlowski
2014-09-15 14:36 ` Javier Martinez Canillas
2014-09-15 14:36 ` Javier Martinez Canillas
2014-09-15 14:56 ` Krzysztof Kozlowski [this message]
2014-09-15 14:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410792966.883.2.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@dowhile0.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.