All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lidong Zhong <lzhong@suse.com>
To: lvm-devel@redhat.com
Subject: [PATCH] pvcreate: check the label after writing
Date: Fri, 26 Sep 2014 11:21:33 +0800	[thread overview]
Message-ID: <1411701693.1629.3.camel@suse.site> (raw)
In-Reply-To: <5423D42C.60106@redhat.com>

Hi list,
> Dne 25.9.2014 v 09:52 Zdenek Kabelac napsal(a):
> > Dne 25.9.2014 v 04:20 Lidong Zhong napsal(a):
> >> Some device will place metadata area at the beginning part and writing
> >> label may fail.Take our test for example, when running pvcreate on a CDL
> >> formatted DASD device(without partition), it shows successfully create
> >> a pv, but the label is not written on the second sector and pvs shows
> >> nothing. Although it is not supposed to run lvm on dasd device, it's a
> >> friendly behavior to check the label and return error if it fails.
> >
> > Hmm - if device drive tells you - it has accepted and written some bytes
> > on your storage device - they really should be written there.
> >
> > So IMHO driver should not lie and reject write request with error ?
> >
> > Otherwise you would need to validate every single written byte by LVM ?
> >
> > Maybe DASD devices should by automatically ignored by lvm filtering
> > as unusable device for PV  (just like i.e. too small devices)
> 
> It looks like DASD device is somehow supported by 'parted'
> 
> And there are some very 'innovative' ways how to work with this device and 
> detect where the write is actually allowed/supported.
> 
> So it seems like lvm2 would need to learn those bits on how to manipulate DASD 
> devices.
> 
> And also tools like blkid then needs to look at proper places how to recognize 
> such device's signature.
> 
> Anyway - the patch you've proposed is likely not valid.
> 
> Device driver for DASD should reject write attempt to privileged disk area 
> with 'error'.
> 
> It would be probably fair to disable/ignore DASD device in lvm2 for now - 
> since we clearly do not understand layout of this device and try to store PV 
> header into wrong place - and someone needs to write handled for this devices 
> to reenable support for it.
> 
That's reasonable. we added DASD device in the filter to fix this
problem.
Thank you

> There is BZ http://bugzilla.redhat.com/show_bug.cgi?id=1058326
> which is likely related to the same issue.
> 
> Zdenek
> 
> --
> lvm-devel mailing list
> lvm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/lvm-devel
> 

-- 
Best regards,
Lidong




      reply	other threads:[~2014-09-26  3:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  2:20 [PATCH] pvcreate: check the label after writing Lidong Zhong
2014-09-25  7:52 ` Zdenek Kabelac
2014-09-25  8:37   ` Zdenek Kabelac
2014-09-26  3:21     ` Lidong Zhong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411701693.1629.3.camel@suse.site \
    --to=lzhong@suse.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.