From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Weike Chen <alvin.chen@intel.com>,
Eric Miao <eric.y.miao@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@intel.com>,
Hock Leong Kweh <hock.leong.kweh@intel.com>,
Boon Leong Ong <boon.leong.ong@intel.com>,
Raymond Tan <raymond.tan@intel.com>
Subject: Re: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000
Date: Fri, 26 Sep 2014 17:22:37 +0300 [thread overview]
Message-ID: <1411741357.22717.4.camel@linux.intel.com> (raw)
In-Reply-To: <20140926100832.GE27755@sirena.org.uk>
On Fri, 2014-09-26 at 11:08 +0100, Mark Brown wrote:
> On Fri, Sep 26, 2014 at 10:25:49AM -0700, Weike Chen wrote:
[]
> It might also be helpful for review to have two
> patches, one splitting things out into the functions and another adding
> the Quark support.
I also suggest to go this way.
>
> > +/* see Quark SPI data sheet for implementation rationale */
> > +static u32 quark_x1000_set_clk_regvals(u32 rate, u32 *dds, u32 *clk_div)
> > +{
>
> Please document this in the driver - I don't know if this datasheet is
> public but even if it is it may not stay that way.
Datasheet is public.
I'm just wondering if we can use just a formula instead of table.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000
Date: Fri, 26 Sep 2014 17:22:37 +0300 [thread overview]
Message-ID: <1411741357.22717.4.camel@linux.intel.com> (raw)
In-Reply-To: <20140926100832.GE27755@sirena.org.uk>
On Fri, 2014-09-26 at 11:08 +0100, Mark Brown wrote:
> On Fri, Sep 26, 2014 at 10:25:49AM -0700, Weike Chen wrote:
[]
> It might also be helpful for review to have two
> patches, one splitting things out into the functions and another adding
> the Quark support.
I also suggest to go this way.
>
> > +/* see Quark SPI data sheet for implementation rationale */
> > +static u32 quark_x1000_set_clk_regvals(u32 rate, u32 *dds, u32 *clk_div)
> > +{
>
> Please document this in the driver - I don't know if this datasheet is
> public but even if it is it may not stay that way.
Datasheet is public.
I'm just wondering if we can use just a formula instead of table.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2014-09-26 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 17:25 [PATCH] SPI: spi-pxa2xx: Add support for Intel Quark X1000 SPI controller Weike Chen
2014-09-26 17:25 ` Weike Chen
2014-09-26 17:25 ` Weike Chen
2014-09-26 17:25 ` [PATCH] SPI: spi-pxa2xx: SPI support for Intel Quark X1000 Weike Chen
2014-09-26 17:25 ` Weike Chen
[not found] ` <1411752349-31490-2-git-send-email-alvin.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-26 10:08 ` Mark Brown
2014-09-26 10:08 ` Mark Brown
2014-09-26 10:08 ` Mark Brown
2014-09-26 14:22 ` Andy Shevchenko [this message]
2014-09-26 14:22 ` Andy Shevchenko
[not found] ` <1411741357.22717.4.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-28 3:23 ` Chen, Alvin
2014-09-28 3:23 ` Chen, Alvin
2014-09-28 3:23 ` Chen, Alvin
[not found] ` <20140926100832.GE27755-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-28 3:15 ` Chen, Alvin
2014-09-28 3:15 ` Chen, Alvin
2014-09-28 3:15 ` Chen, Alvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411741357.22717.4.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alvin.chen@intel.com \
--cc=boon.leong.ong@intel.com \
--cc=broonie@kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mika.westerberg@intel.com \
--cc=raymond.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.