Re: [PATCH] xen: sanity check input and serialize vcpu data in sched_rt.c

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1280 bytes --]

On lun, 2014-09-29 at 09:09 +0100, Jan Beulich wrote:
> >>> On 26.09.14 at 20:29, <mengxu@cis.upenn.edu> wrote:
> > Sanity check input params in rt_dom_cntl();
> > Serialize rt_dom_cntl() against the global lock;
> > Move the call to rt_update_deadline() from _alloc to _insert.
> 
> Regarding this last sentence - the patch clearly does more in this
> regard than just move the call from _alloc or _insert. Please make
> sure your description matches the patch (which doesn't necessarily
> mean enumerating all places it gets moved from - all I'd like to see
> is that description and implementation don't disagree).
> 
> And aren't the two changes here independent anyway? In which
> case submitting them as two patches might be better?
> 
Indeed, two patch is what we want.

Also, the threading. According to my MUA, the mail with the patch is a
reply to a message from the v4 patch series. Meng, as this is a new
submission, the best thing is always to start a new thread.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel