* [PATCH for-4.5] tools/libxl: Initialise rc on error paths of libxl_domain_remus_start()
@ 2014-10-01 10:09 Andrew Cooper
2014-10-01 10:29 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2014-10-01 10:09 UTC (permalink / raw)
To: Xen-devel
Cc: Wei Liu, Ian Campbell, Andrew Cooper, Ian Jackson,
Shriram Rajagopalan, Yang Hongyang
Coverity-ID: 1242320
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Shriram Rajagopalan <rshriram@cs.ubc.ca>
CC: Yang Hongyang <yanghy@cn.fujitsu.com>
---
tools/libxl/libxl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 9f629c4..3f0a7ff 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -816,6 +816,7 @@ int libxl_domain_remus_start(libxl_ctx *ctx, libxl_domain_remus_info *info,
!libxl_defbool_val(info->diskbuf))) {
LOG(ERROR, "Unsafe mode must be enabled to replicate to /dev/null,"
"disable network buffering and disk replication");
+ rc = ERROR_FAIL;
goto out;
}
@@ -839,6 +840,7 @@ int libxl_domain_remus_start(libxl_ctx *ctx, libxl_domain_remus_info *info,
if (libxl_defbool_val(info->netbuf)) {
if (!libxl__netbuffer_enabled(gc)) {
LOG(ERROR, "Remus: No support for network buffering");
+ rc = ERROR_FAIL;
goto out;
}
rds->device_kind_flags |= (1 << LIBXL__DEVICE_KIND_VIF);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for-4.5] tools/libxl: Initialise rc on error paths of libxl_domain_remus_start()
2014-10-01 10:09 [PATCH for-4.5] tools/libxl: Initialise rc on error paths of libxl_domain_remus_start() Andrew Cooper
@ 2014-10-01 10:29 ` Ian Campbell
2014-10-01 12:18 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2014-10-01 10:29 UTC (permalink / raw)
To: Andrew Cooper
Cc: Shriram Rajagopalan, Wei Liu, Yang Hongyang, Ian Jackson,
Xen-devel
On Wed, 2014-10-01 at 11:09 +0100, Andrew Cooper wrote:
> Coverity-ID: 1242320
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-4.5] tools/libxl: Initialise rc on error paths of libxl_domain_remus_start()
2014-10-01 10:29 ` Ian Campbell
@ 2014-10-01 12:18 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-10-01 12:18 UTC (permalink / raw)
To: Andrew Cooper
Cc: Shriram Rajagopalan, Ian Jackson, Yang Hongyang, Wei Liu,
Xen-devel
On Wed, 2014-10-01 at 11:29 +0100, Ian Campbell wrote:
> On Wed, 2014-10-01 at 11:09 +0100, Andrew Cooper wrote:
> > Coverity-ID: 1242320
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
>
And applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-01 12:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-01 10:09 [PATCH for-4.5] tools/libxl: Initialise rc on error paths of libxl_domain_remus_start() Andrew Cooper
2014-10-01 10:29 ` Ian Campbell
2014-10-01 12:18 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.