From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Romeo Cane <romeo.cane.ext@coriant.com>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: fix sys_call_table declaration
Date: Fri, 03 Oct 2014 07:34:34 +1000 [thread overview]
Message-ID: <1412285674.28143.35.camel@pasglop> (raw)
In-Reply-To: <20141002144131.GA3855@rcane-VirtualBox>
On Thu, 2014-10-02 at 15:41 +0100, Romeo Cane wrote:
> Declaring sys_call_table as a pointer causes the compiler to generate the wrong lookup code in arch_syscall_addr
Care to elaborate ?
Ben.
> Signed-off-by: Romeo Cane <romeo.cane.ext@coriant.com>
> ---
> arch/powerpc/include/asm/syscall.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/syscall.h b/arch/powerpc/include/asm/syscall.h
> index b54b2ad..528ba9d 100644
> --- a/arch/powerpc/include/asm/syscall.h
> +++ b/arch/powerpc/include/asm/syscall.h
> @@ -17,7 +17,7 @@
>
> /* ftrace syscalls requires exporting the sys_call_table */
> #ifdef CONFIG_FTRACE_SYSCALLS
> -extern const unsigned long *sys_call_table;
> +extern const unsigned long sys_call_table[];
> #endif /* CONFIG_FTRACE_SYSCALLS */
>
> static inline long syscall_get_nr(struct task_struct *task,
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Romeo Cane <romeo.cane.ext@coriant.com>
Cc: Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: fix sys_call_table declaration
Date: Fri, 03 Oct 2014 07:34:34 +1000 [thread overview]
Message-ID: <1412285674.28143.35.camel@pasglop> (raw)
In-Reply-To: <20141002144131.GA3855@rcane-VirtualBox>
On Thu, 2014-10-02 at 15:41 +0100, Romeo Cane wrote:
> Declaring sys_call_table as a pointer causes the compiler to generate the wrong lookup code in arch_syscall_addr
Care to elaborate ?
Ben.
> Signed-off-by: Romeo Cane <romeo.cane.ext@coriant.com>
> ---
> arch/powerpc/include/asm/syscall.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/syscall.h b/arch/powerpc/include/asm/syscall.h
> index b54b2ad..528ba9d 100644
> --- a/arch/powerpc/include/asm/syscall.h
> +++ b/arch/powerpc/include/asm/syscall.h
> @@ -17,7 +17,7 @@
>
> /* ftrace syscalls requires exporting the sys_call_table */
> #ifdef CONFIG_FTRACE_SYSCALLS
> -extern const unsigned long *sys_call_table;
> +extern const unsigned long sys_call_table[];
> #endif /* CONFIG_FTRACE_SYSCALLS */
>
> static inline long syscall_get_nr(struct task_struct *task,
next prev parent reply other threads:[~2014-10-02 21:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 14:41 [PATCH] powerpc: fix sys_call_table declaration Romeo Cane
2014-10-02 14:41 ` Romeo Cane
2014-10-02 21:34 ` Benjamin Herrenschmidt [this message]
2014-10-02 21:34 ` Benjamin Herrenschmidt
2014-10-03 10:00 ` Romeo Cane
2014-10-03 10:00 ` Romeo Cane
2014-10-07 12:15 ` Michael Ellerman
2014-10-07 12:15 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412285674.28143.35.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=romeo.cane.ext@coriant.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.