From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
tiwai@suse.de, tj@kernel.org, arjan@linux.intel.com
Cc: teg@jklm.no, rmilasan@suse.com, werner@suse.com, oleg@redhat.com,
hare@suse.com, bpoirier@suse.de, santosh@chelsio.com,
pmladek@suse.cz, dbueso@suse.com, mcgrof@suse.com,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH v2 1/7] taint: add TAINT_DEBUG for invasive debugging features
Date: Fri, 3 Oct 2014 14:44:37 -0700 [thread overview]
Message-ID: <1412372683-2003-2-git-send-email-mcgrof@do-not-panic.com> (raw)
In-Reply-To: <1412372683-2003-1-git-send-email-mcgrof@do-not-panic.com>
From: "Luis R. Rodriguez" <mcgrof@suse.com>
At times we may add module parameters or debugging / testing
kernel features, when enabled though we don't really want
to be spending time debugging them. Add a taint flag for
this to avoid spurious bug reports.
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Tejun Heo <tj@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
---
Documentation/sysctl/kernel.txt | 1 +
include/linux/kernel.h | 1 +
kernel/module.c | 4 ++--
kernel/panic.c | 2 ++
4 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/sysctl/kernel.txt b/Documentation/sysctl/kernel.txt
index f79eb96..1780a68 100644
--- a/Documentation/sysctl/kernel.txt
+++ b/Documentation/sysctl/kernel.txt
@@ -827,6 +827,7 @@ can be ORed together:
8192 - An unsigned module has been loaded in a kernel supporting module
signature.
16384 - A soft lockup has previously occurred on the system.
+32768 - A possibly disruptive testing / debug kernel feature has been enabled
==============================================================
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 95624be..8901809 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -471,6 +471,7 @@ extern enum system_states {
#define TAINT_OOT_MODULE 12
#define TAINT_UNSIGNED_MODULE 13
#define TAINT_SOFTLOCKUP 14
+#define TAINT_DEBUG 15
extern const char hex_asc[];
#define hex_asc_lo(x) hex_asc[((x) & 0x0f)]
diff --git a/kernel/module.c b/kernel/module.c
index 03214bd2..3f7d02a 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1013,8 +1013,8 @@ static size_t module_flags_taint(struct module *mod, char *buf)
buf[l++] = 'E';
/*
* TAINT_FORCED_RMMOD: could be added.
- * TAINT_CPU_OUT_OF_SPEC, TAINT_MACHINE_CHECK, TAINT_BAD_PAGE don't
- * apply to modules.
+ * TAINT_CPU_OUT_OF_SPEC, TAINT_MACHINE_CHECK, TAINT_BAD_PAGE
+ * and TAINT_DEBUG don't apply to modules.
*/
return l;
}
diff --git a/kernel/panic.c b/kernel/panic.c
index d09dc5c..8e5a77b 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -225,6 +225,7 @@ static const struct tnt tnts[] = {
{ TAINT_OOT_MODULE, 'O', ' ' },
{ TAINT_UNSIGNED_MODULE, 'E', ' ' },
{ TAINT_SOFTLOCKUP, 'L', ' ' },
+ { TAINT_DEBUG, 'T', ' ' },
};
/**
@@ -244,6 +245,7 @@ static const struct tnt tnts[] = {
* 'I' - Working around severe firmware bug.
* 'O' - Out-of-tree module has been loaded.
* 'E' - Unsigned module has been loaded.
+ * 'T' - System has enabled an intrusive testing / debug kernel feature.
*
* The string is overwritten by the next call to print_tainted().
*/
--
2.1.1
next prev parent reply other threads:[~2014-10-04 0:18 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 21:44 [PATCH v2 0/7] driver-core: async probe support Luis R. Rodriguez
2014-10-03 21:44 ` Luis R. Rodriguez [this message]
2014-10-15 5:35 ` [PATCH v2 1/7] taint: add TAINT_DEBUG for invasive debugging features Rusty Russell
2014-10-20 20:37 ` Luis R. Rodriguez
2014-10-03 21:44 ` [Cocci] [PATCH v2 2/7] module: add extra argument for parse_params() callback Luis R. Rodriguez
2014-10-03 21:44 ` Luis R. Rodriguez
2014-10-04 12:55 ` [Cocci] " SF Markus Elfring
2014-10-04 12:55 ` SF Markus Elfring
2014-10-06 20:38 ` Luis R. Rodriguez
2014-10-06 20:38 ` Luis R. Rodriguez
2014-10-06 21:06 ` SF Markus Elfring
2014-10-06 21:06 ` SF Markus Elfring
2014-10-06 22:15 ` Luis R. Rodriguez
2014-10-06 22:15 ` Luis R. Rodriguez
2014-10-15 5:35 ` Rusty Russell
2014-10-15 5:35 ` Rusty Russell
2014-10-03 21:44 ` [PATCH v2 3/7] driver-core: enable drivers to opt-out of async probe Luis R. Rodriguez
2014-10-03 21:44 ` [PATCH v2 4/7] amd64_edac: enforce synchronous probe Luis R. Rodriguez
2014-10-03 21:44 ` [PATCH v2 5/7] driver-core: generalize freeing driver private member Luis R. Rodriguez
2014-10-03 21:44 ` [PATCH v2 6/7] driver-core: add driver module asynchronous probe support Luis R. Rodriguez
2014-10-03 21:44 ` Luis R. Rodriguez
2014-10-03 21:44 ` [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules Luis R. Rodriguez
2014-10-03 21:44 ` Luis R. Rodriguez
2014-10-06 20:19 ` Tejun Heo
2014-10-06 20:19 ` Tejun Heo
2014-10-06 20:19 ` Tejun Heo
2014-10-06 20:36 ` Luis R. Rodriguez
2014-10-06 20:36 ` Luis R. Rodriguez
2014-10-06 20:36 ` Luis R. Rodriguez
2014-10-06 21:01 ` Tejun Heo
2014-10-06 21:01 ` Tejun Heo
2014-10-06 21:01 ` Tejun Heo
2014-10-06 23:10 ` Luis R. Rodriguez
2014-10-06 23:10 ` Luis R. Rodriguez
2014-10-06 23:10 ` Luis R. Rodriguez
2014-10-07 17:34 ` Tejun Heo
2014-10-07 17:34 ` Tejun Heo
2014-10-07 17:34 ` Tejun Heo
2014-10-07 17:50 ` Luis R. Rodriguez
2014-10-07 17:50 ` Luis R. Rodriguez
2014-10-07 17:50 ` Luis R. Rodriguez
2014-10-07 17:55 ` Tejun Heo
2014-10-07 17:55 ` Tejun Heo
2014-10-07 17:55 ` Tejun Heo
2014-10-07 18:55 ` Luis R. Rodriguez
2014-10-07 18:55 ` Luis R. Rodriguez
2014-10-07 18:55 ` Luis R. Rodriguez
2014-10-07 19:07 ` Luis R. Rodriguez
2014-10-07 19:07 ` Luis R. Rodriguez
2014-10-07 19:07 ` Luis R. Rodriguez
2014-10-06 20:41 ` Dmitry Torokhov
2014-10-06 20:41 ` Dmitry Torokhov
2014-10-06 20:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412372683-2003-2-git-send-email-mcgrof@do-not-panic.com \
--to=mcgrof@do-not-panic.com \
--cc=arjan@linux.intel.com \
--cc=bpoirier@suse.de \
--cc=dbueso@suse.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=oleg@redhat.com \
--cc=pmladek@suse.cz \
--cc=rmilasan@suse.com \
--cc=rusty@rustcorp.com.au \
--cc=santosh@chelsio.com \
--cc=teg@jklm.no \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
--cc=werner@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.