From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
tiwai@suse.de, tj@kernel.org, arjan@linux.intel.com
Cc: teg@jklm.no, rmilasan@suse.com, werner@suse.com, oleg@redhat.com,
hare@suse.com, bpoirier@suse.de, santosh@chelsio.com,
pmladek@suse.cz, dbueso@suse.com, mcgrof@suse.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/7] driver-core: generalize freeing driver private member
Date: Fri, 3 Oct 2014 14:44:41 -0700 [thread overview]
Message-ID: <1412372683-2003-6-git-send-email-mcgrof@do-not-panic.com> (raw)
In-Reply-To: <1412372683-2003-1-git-send-email-mcgrof@do-not-panic.com>
From: "Luis R. Rodriguez" <mcgrof@suse.com>
This will be used later.
Cc: Tejun Heo <tj@kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
---
drivers/base/bus.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 83e910a..a5f41e4 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -657,6 +657,15 @@ static ssize_t uevent_store(struct device_driver *drv, const char *buf,
}
static DRIVER_ATTR_WO(uevent);
+static void remove_driver_private(struct device_driver *drv)
+{
+ struct driver_private *priv = drv->p;
+
+ kobject_put(&priv->kobj);
+ kfree(priv);
+ drv->p = NULL;
+}
+
/**
* bus_add_driver - Add a driver to the bus.
* @drv: driver.
@@ -719,9 +728,7 @@ int bus_add_driver(struct device_driver *drv)
return 0;
out_unregister:
- kobject_put(&priv->kobj);
- kfree(drv->p);
- drv->p = NULL;
+ remove_driver_private(drv);
out_put_bus:
bus_put(bus);
return error;
--
2.1.1
next prev parent reply other threads:[~2014-10-04 0:14 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 21:44 [PATCH v2 0/7] driver-core: async probe support Luis R. Rodriguez
2014-10-03 21:44 ` [PATCH v2 1/7] taint: add TAINT_DEBUG for invasive debugging features Luis R. Rodriguez
2014-10-15 5:35 ` Rusty Russell
2014-10-20 20:37 ` Luis R. Rodriguez
2014-10-03 21:44 ` [Cocci] [PATCH v2 2/7] module: add extra argument for parse_params() callback Luis R. Rodriguez
2014-10-03 21:44 ` Luis R. Rodriguez
2014-10-04 12:55 ` [Cocci] " SF Markus Elfring
2014-10-04 12:55 ` SF Markus Elfring
2014-10-06 20:38 ` Luis R. Rodriguez
2014-10-06 20:38 ` Luis R. Rodriguez
2014-10-06 21:06 ` SF Markus Elfring
2014-10-06 21:06 ` SF Markus Elfring
2014-10-06 22:15 ` Luis R. Rodriguez
2014-10-06 22:15 ` Luis R. Rodriguez
2014-10-15 5:35 ` Rusty Russell
2014-10-15 5:35 ` Rusty Russell
2014-10-03 21:44 ` [PATCH v2 3/7] driver-core: enable drivers to opt-out of async probe Luis R. Rodriguez
2014-10-03 21:44 ` [PATCH v2 4/7] amd64_edac: enforce synchronous probe Luis R. Rodriguez
2014-10-03 21:44 ` Luis R. Rodriguez [this message]
2014-10-03 21:44 ` [PATCH v2 6/7] driver-core: add driver module asynchronous probe support Luis R. Rodriguez
2014-10-03 21:44 ` Luis R. Rodriguez
2014-10-03 21:44 ` [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules Luis R. Rodriguez
2014-10-03 21:44 ` Luis R. Rodriguez
2014-10-06 20:19 ` Tejun Heo
2014-10-06 20:19 ` Tejun Heo
2014-10-06 20:19 ` Tejun Heo
2014-10-06 20:36 ` Luis R. Rodriguez
2014-10-06 20:36 ` Luis R. Rodriguez
2014-10-06 20:36 ` Luis R. Rodriguez
2014-10-06 21:01 ` Tejun Heo
2014-10-06 21:01 ` Tejun Heo
2014-10-06 21:01 ` Tejun Heo
2014-10-06 23:10 ` Luis R. Rodriguez
2014-10-06 23:10 ` Luis R. Rodriguez
2014-10-06 23:10 ` Luis R. Rodriguez
2014-10-07 17:34 ` Tejun Heo
2014-10-07 17:34 ` Tejun Heo
2014-10-07 17:34 ` Tejun Heo
2014-10-07 17:50 ` Luis R. Rodriguez
2014-10-07 17:50 ` Luis R. Rodriguez
2014-10-07 17:50 ` Luis R. Rodriguez
2014-10-07 17:55 ` Tejun Heo
2014-10-07 17:55 ` Tejun Heo
2014-10-07 17:55 ` Tejun Heo
2014-10-07 18:55 ` Luis R. Rodriguez
2014-10-07 18:55 ` Luis R. Rodriguez
2014-10-07 18:55 ` Luis R. Rodriguez
2014-10-07 19:07 ` Luis R. Rodriguez
2014-10-07 19:07 ` Luis R. Rodriguez
2014-10-07 19:07 ` Luis R. Rodriguez
2014-10-06 20:41 ` Dmitry Torokhov
2014-10-06 20:41 ` Dmitry Torokhov
2014-10-06 20:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412372683-2003-6-git-send-email-mcgrof@do-not-panic.com \
--to=mcgrof@do-not-panic.com \
--cc=arjan@linux.intel.com \
--cc=bpoirier@suse.de \
--cc=dbueso@suse.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=oleg@redhat.com \
--cc=pmladek@suse.cz \
--cc=rmilasan@suse.com \
--cc=santosh@chelsio.com \
--cc=teg@jklm.no \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
--cc=werner@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.