From: Paul Bolle <pebolle@tiscali.nl>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2] [media] Remove references to non-existent PLAT_S5P symbol
Date: Mon, 06 Oct 2014 18:36:35 +0200 [thread overview]
Message-ID: <1412613395.8561.1.camel@x220> (raw)
In-Reply-To: <1412611806-9346-1-git-send-email-s.nawrocki@samsung.com>
On Mon, 2014-10-06 at 18:10 +0200, Sylwester Nawrocki wrote:
> The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
> ("ARM: SAMSUNG: Remove remaining legacy code"). However, there
> are still some references to that symbol left, fix that by
> substituting them with ARCH_S5PV210.
>
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Thanks for picking this up!
Should
Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
be added so this will end up in stable for v3.17?
> drivers/media/platform/Kconfig | 6 +++---
> drivers/media/platform/exynos4-is/Kconfig | 2 +-
> drivers/media/platform/s5p-tv/Kconfig | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index bee9074..3aac88f 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -166,7 +166,7 @@ config VIDEO_MEM2MEM_DEINTERLACE
> config VIDEO_SAMSUNG_S5P_G2D
> tristate "Samsung S5P and EXYNOS4 G2D 2d graphics accelerator driver"
> depends on VIDEO_DEV && VIDEO_V4L2
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> @@ -178,7 +178,7 @@ config VIDEO_SAMSUNG_S5P_G2D
> config VIDEO_SAMSUNG_S5P_JPEG
> tristate "Samsung S5P/Exynos3250/Exynos4 JPEG codec driver"
> depends on VIDEO_DEV && VIDEO_V4L2
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> @@ -189,7 +189,7 @@ config VIDEO_SAMSUNG_S5P_JPEG
> config VIDEO_SAMSUNG_S5P_MFC
> tristate "Samsung S5P MFC Video Codec"
> depends on VIDEO_DEV && VIDEO_V4L2
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
> default n
> diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig
> index 77c9512..b7b2e47 100644
> --- a/drivers/media/platform/exynos4-is/Kconfig
> +++ b/drivers/media/platform/exynos4-is/Kconfig
> @@ -2,7 +2,7 @@
> config VIDEO_SAMSUNG_EXYNOS4_IS
> bool "Samsung S5P/EXYNOS4 SoC series Camera Subsystem driver"
> depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> - depends on (PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST)
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> depends on OF && COMMON_CLK
> help
> Say Y here to enable camera host interface devices for
> diff --git a/drivers/media/platform/s5p-tv/Kconfig b/drivers/media/platform/s5p-tv/Kconfig
> index a9d56f8..beb180e 100644
> --- a/drivers/media/platform/s5p-tv/Kconfig
> +++ b/drivers/media/platform/s5p-tv/Kconfig
> @@ -9,7 +9,7 @@
> config VIDEO_SAMSUNG_S5P_TV
> bool "Samsung TV driver for S5P platform"
> depends on PM_RUNTIME
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> default n
> ---help---
> Say Y here to enable selecting the TV output devices for
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] [media] Remove references to non-existent PLAT_S5P symbol
Date: Mon, 06 Oct 2014 18:36:35 +0200 [thread overview]
Message-ID: <1412613395.8561.1.camel@x220> (raw)
In-Reply-To: <1412611806-9346-1-git-send-email-s.nawrocki@samsung.com>
On Mon, 2014-10-06 at 18:10 +0200, Sylwester Nawrocki wrote:
> The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
> ("ARM: SAMSUNG: Remove remaining legacy code"). However, there
> are still some references to that symbol left, fix that by
> substituting them with ARCH_S5PV210.
>
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Thanks for picking this up!
Should
Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
be added so this will end up in stable for v3.17?
> drivers/media/platform/Kconfig | 6 +++---
> drivers/media/platform/exynos4-is/Kconfig | 2 +-
> drivers/media/platform/s5p-tv/Kconfig | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index bee9074..3aac88f 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -166,7 +166,7 @@ config VIDEO_MEM2MEM_DEINTERLACE
> config VIDEO_SAMSUNG_S5P_G2D
> tristate "Samsung S5P and EXYNOS4 G2D 2d graphics accelerator driver"
> depends on VIDEO_DEV && VIDEO_V4L2
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> @@ -178,7 +178,7 @@ config VIDEO_SAMSUNG_S5P_G2D
> config VIDEO_SAMSUNG_S5P_JPEG
> tristate "Samsung S5P/Exynos3250/Exynos4 JPEG codec driver"
> depends on VIDEO_DEV && VIDEO_V4L2
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> @@ -189,7 +189,7 @@ config VIDEO_SAMSUNG_S5P_JPEG
> config VIDEO_SAMSUNG_S5P_MFC
> tristate "Samsung S5P MFC Video Codec"
> depends on VIDEO_DEV && VIDEO_V4L2
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
> default n
> diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig
> index 77c9512..b7b2e47 100644
> --- a/drivers/media/platform/exynos4-is/Kconfig
> +++ b/drivers/media/platform/exynos4-is/Kconfig
> @@ -2,7 +2,7 @@
> config VIDEO_SAMSUNG_EXYNOS4_IS
> bool "Samsung S5P/EXYNOS4 SoC series Camera Subsystem driver"
> depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> - depends on (PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST)
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> depends on OF && COMMON_CLK
> help
> Say Y here to enable camera host interface devices for
> diff --git a/drivers/media/platform/s5p-tv/Kconfig b/drivers/media/platform/s5p-tv/Kconfig
> index a9d56f8..beb180e 100644
> --- a/drivers/media/platform/s5p-tv/Kconfig
> +++ b/drivers/media/platform/s5p-tv/Kconfig
> @@ -9,7 +9,7 @@
> config VIDEO_SAMSUNG_S5P_TV
> bool "Samsung TV driver for S5P platform"
> depends on PM_RUNTIME
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> default n
> ---help---
> Say Y here to enable selecting the TV output devices for
Paul Bolle
next prev parent reply other threads:[~2014-10-06 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 16:10 [PATCH v2] [media] Remove references to non-existent PLAT_S5P symbol Sylwester Nawrocki
2014-10-06 16:10 ` Sylwester Nawrocki
2014-10-06 16:36 ` Paul Bolle [this message]
2014-10-06 16:36 ` Paul Bolle
2014-10-07 9:11 ` Sylwester Nawrocki
2014-10-07 9:11 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412613395.8561.1.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.