All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] fetcher: fix BB_STRICT_CHECKSUM datatype check
@ 2014-10-10 17:02 Alejandro Hernandez
  2014-10-10 17:12 ` Christopher Larson
  0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Hernandez @ 2014-10-10 17:02 UTC (permalink / raw)
  To: bitbake-devel

Forcing strict to be a string, to avoid problems when performing comparisons

[YOCTO #6762]

Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
---
 lib/bb/fetch2/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
index 10c3346..5341ebf 100644
--- a/lib/bb/fetch2/__init__.py
+++ b/lib/bb/fetch2/__init__.py
@@ -543,7 +543,7 @@ def verify_checksum(ud, d):
 
     if ud.method.recommends_checksum(ud):
         # If strict checking enabled and neither sum defined, raise error
-        strict = d.getVar("BB_STRICT_CHECKSUM", "1") or "0"
+        strict = d.getVar("BB_STRICT_CHECKSUM", True) or "0"
         if (strict == "1") and not (ud.md5_expected or ud.sha256_expected):
             logger.error('No checksum specified for %s, please add at least one to the recipe:\n'
                              'SRC_URI[%s] = "%s"\nSRC_URI[%s] = "%s"' %
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] fetcher: fix BB_STRICT_CHECKSUM datatype check
  2014-10-10 17:02 [PATCH v3] fetcher: fix BB_STRICT_CHECKSUM datatype check Alejandro Hernandez
@ 2014-10-10 17:12 ` Christopher Larson
  0 siblings, 0 replies; 2+ messages in thread
From: Christopher Larson @ 2014-10-10 17:12 UTC (permalink / raw)
  To: Alejandro Hernandez; +Cc: bitbake-devel@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Fri, Oct 10, 2014 at 10:02 AM, Alejandro Hernandez <
alejandro.hernandez@linux.intel.com> wrote:

> Forcing strict to be a string, to avoid problems when performing
> comparisons
>
> [YOCTO #6762]
>
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
>

This commit message doesn't reflect what this commit does. It's fixing the
call to getVar, not changing whether strict is a string or not.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1038 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-10 17:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 17:02 [PATCH v3] fetcher: fix BB_STRICT_CHECKSUM datatype check Alejandro Hernandez
2014-10-10 17:12 ` Christopher Larson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.