All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
	Jan Beulich <jbeulich@suse.com>,
	stefano.stabellini@citrix.com
Subject: Re: [PATCH v2 for 4.5] arm32: fix build after 063188f4b3
Date: Tue, 14 Oct 2014 10:15:57 +0100	[thread overview]
Message-ID: <1413278157.1497.13.camel@citrix.com> (raw)
In-Reply-To: <1413214141-370-1-git-send-email-julien.grall@linaro.org>

On Mon, 2014-10-13 at 16:29 +0100, Julien Grall wrote:

> +GLOBAL(do_smc)

> +GLOBAL(do_smc)

These should both be ENTRY.

> +int do_smc(register_t function_id, ...);

Are you sure that the variadic function calling convention is the same
as for a regular function call? I'm not entirely clear having read
AAPCS, it says they are marshalled according to "the standard base". 

I think it would probably be safer to declare this guy as taking 3-4
arguments and pass in 0 for the unused one. You could wrap in
do_smc<N>() helpers if you really wanted.

I'd prefer to name this call_smc, do_foo tends to be used on the callee
side of exception things (e.g. do_hypervisor_trap etc, do_psci_blah).

Ian.

  parent reply	other threads:[~2014-10-14  9:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13 15:29 [PATCH v2 for 4.5] arm32: fix build after 063188f4b3 Julien Grall
2014-10-13 15:39 ` Julien Grall
2014-10-13 15:49 ` Jan Beulich
2014-10-13 16:05   ` Julien Grall
2014-10-13 15:51 ` Jan Beulich
2014-10-13 16:05   ` Julien Grall
2014-10-13 16:06 ` Stefano Stabellini
2014-10-13 16:49   ` Julien Grall
2014-10-13 17:01     ` Stefano Stabellini
2014-10-13 17:05       ` Julien Grall
2014-10-14  9:15 ` Ian Campbell [this message]
2014-10-14 12:43   ` Julien Grall
2014-10-14 12:57     ` Ian Campbell
2014-10-14 13:06       ` Julien Grall
2014-10-14 13:13         ` Jan Beulich
2014-10-14 13:18           ` Ian Campbell
2014-10-14 19:09           ` Tim Deegan
2014-10-15  7:31             ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2014-10-14 15:52 Julien Grall
2014-10-14 16:29 ` Jan Beulich
2014-10-14 16:31   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413278157.1497.13.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.