All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
	stefano.stabellini@citrix.com, ian.campbell@citrix.com
Subject: Re: [PATCH v2 for 4.5] arm32: fix build after 063188f4b3
Date: Mon, 13 Oct 2014 17:05:48 +0100	[thread overview]
Message-ID: <543BF85C.4070109@linaro.org> (raw)
In-Reply-To: <543C111B020000780003E67B@mail.emea.novell.com>

Hi Jan,

On 10/13/2014 04:51 PM, Jan Beulich wrote:
>>>> On 13.10.14 at 17:29, <julien.grall@linaro.org> wrote:
>> --- /dev/null
>> +++ b/xen/arch/arm/arm32/smc.S
>> @@ -0,0 +1,19 @@
>> +/*
>> + * xen/arch/arm/arm32/smc.S
>> + *
>> + * Wrapper for Secure Monitors Calls
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +GLOBAL(do_smc)
>> +        smc   #0
>> +        mov   pc, lr
> 
> If you defined a little "ret" helper macro there wouldn't be a need
> for separate files for 32- and 64-bit.

Good point. I will give a look to this solution.

Regards,

-- 
Julien Grall

  reply	other threads:[~2014-10-13 16:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13 15:29 [PATCH v2 for 4.5] arm32: fix build after 063188f4b3 Julien Grall
2014-10-13 15:39 ` Julien Grall
2014-10-13 15:49 ` Jan Beulich
2014-10-13 16:05   ` Julien Grall
2014-10-13 15:51 ` Jan Beulich
2014-10-13 16:05   ` Julien Grall [this message]
2014-10-13 16:06 ` Stefano Stabellini
2014-10-13 16:49   ` Julien Grall
2014-10-13 17:01     ` Stefano Stabellini
2014-10-13 17:05       ` Julien Grall
2014-10-14  9:15 ` Ian Campbell
2014-10-14 12:43   ` Julien Grall
2014-10-14 12:57     ` Ian Campbell
2014-10-14 13:06       ` Julien Grall
2014-10-14 13:13         ` Jan Beulich
2014-10-14 13:18           ` Ian Campbell
2014-10-14 19:09           ` Tim Deegan
2014-10-15  7:31             ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2014-10-14 15:52 Julien Grall
2014-10-14 16:29 ` Jan Beulich
2014-10-14 16:31   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543BF85C.4070109@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=JBeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.