* [PATCH for 4.5] Remove stray blexit()
@ 2014-10-13 19:56 Roy Franz
2014-10-14 6:21 ` Vijay Kilari
0 siblings, 1 reply; 3+ messages in thread
From: Roy Franz @ 2014-10-13 19:56 UTC (permalink / raw)
To: xen-devel, ian.campbell, stefano.stabellini, tim, jbeulich, keir
Cc: Roy Franz, fu.wei
A stray call to blexit() was in the normal processing path for handling
FDTs specified in the config file, causing the EFI boot code to
unconditionally exit. Remove the blexit() call as it should never
have been here.
Signed-off-by: Roy Franz <roy.franz@linaro.org>
---
xen/arch/arm/efi/efi-boot.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index 61cb13a..7abc059 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -359,7 +359,6 @@ static void __init efi_arch_cfg_file_early(EFI_FILE_HANDLE dir_handle, char *sec
{
split_string(name.s);
read_file(dir_handle, s2w(&name), &dtbfile, NULL);
- blexit(NULL);
efi_bs->FreePool(name.w);
}
fdt = fdt_increase_size(&dtbfile, cfg.size + EFI_PAGE_SIZE);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for 4.5] Remove stray blexit()
2014-10-13 19:56 [PATCH for 4.5] Remove stray blexit() Roy Franz
@ 2014-10-14 6:21 ` Vijay Kilari
2014-10-14 9:59 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Vijay Kilari @ 2014-10-14 6:21 UTC (permalink / raw)
To: Roy Franz
Cc: Keir (Xen.org), Ian Campbell, Tim Deegan, xen-devel@lists.xen.org,
Stefano Stabellini, Jan Beulich, fu.wei
On Tue, Oct 14, 2014 at 1:26 AM, Roy Franz <roy.franz@linaro.org> wrote:
> A stray call to blexit() was in the normal processing path for handling
> FDTs specified in the config file, causing the EFI boot code to
> unconditionally exit. Remove the blexit() call as it should never
> have been here.
>
> Signed-off-by: Roy Franz <roy.franz@linaro.org>
> ---
> xen/arch/arm/efi/efi-boot.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index 61cb13a..7abc059 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -359,7 +359,6 @@ static void __init efi_arch_cfg_file_early(EFI_FILE_HANDLE dir_handle, char *sec
> {
> split_string(name.s);
> read_file(dir_handle, s2w(&name), &dtbfile, NULL);
> - blexit(NULL);
> efi_bs->FreePool(name.w);
> }
> fdt = fdt_increase_size(&dtbfile, cfg.size + EFI_PAGE_SIZE);
> --
> 1.9.1
Tested-by: Vijaya Kumar K<Vijaya.Kumar@caviumnetworks.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH for 4.5] Remove stray blexit()
2014-10-14 6:21 ` Vijay Kilari
@ 2014-10-14 9:59 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-10-14 9:59 UTC (permalink / raw)
To: Vijay Kilari
Cc: Keir (Xen.org), Tim Deegan, xen-devel@lists.xen.org, Roy Franz,
Stefano Stabellini, Jan Beulich, fu.wei
On Tue, 2014-10-14 at 11:51 +0530, Vijay Kilari wrote:
> On Tue, Oct 14, 2014 at 1:26 AM, Roy Franz <roy.franz@linaro.org> wrote:
> > A stray call to blexit() was in the normal processing path for handling
> > FDTs specified in the config file, causing the EFI boot code to
> > unconditionally exit. Remove the blexit() call as it should never
> > have been here.
> >
> Tested-by: Vijaya Kumar K<Vijaya.Kumar@caviumnetworks.com>
Acked + applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-14 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-13 19:56 [PATCH for 4.5] Remove stray blexit() Roy Franz
2014-10-14 6:21 ` Vijay Kilari
2014-10-14 9:59 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.