From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Tanya Brokhman <tlinder@codeaurora.org>,
linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Tue, 14 Oct 2014 18:09:03 +0300 [thread overview]
Message-ID: <1413299343.7906.103.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20141014143902.GA9768@arch.hh.imgtec.org>
On Tue, 2014-10-14 at 11:39 -0300, Ezequiel Garcia wrote:
> Please use some pr_fmt for this. Something like this before the headers
> should be enough:
>
> #define pr_fmt(fmt) "UBI: block:" fmt
Sinc ubiblock is a device, there should be a 'struct device' somewhere,
so probably dev_printk() and other dev_*() printing functions would be a
better choice?
--
Artem
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Tanya Brokhman <tlinder@codeaurora.org>,
Richard Weinberger <richard@nod.at>,
open list <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v4] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Tue, 14 Oct 2014 18:09:03 +0300 [thread overview]
Message-ID: <1413299343.7906.103.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20141014143902.GA9768@arch.hh.imgtec.org>
On Tue, 2014-10-14 at 11:39 -0300, Ezequiel Garcia wrote:
> Please use some pr_fmt for this. Something like this before the headers
> should be enough:
>
> #define pr_fmt(fmt) "UBI: block:" fmt
Sinc ubiblock is a device, there should be a 'struct device' somewhere,
so probably dev_printk() and other dev_*() printing functions would be a
better choice?
--
Artem
next prev parent reply other threads:[~2014-10-14 15:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 14:13 [PATCH v4] mtd: ubi: Extend UBI layer debug/messaging capabilities Tanya Brokhman
2014-10-14 14:13 ` Tanya Brokhman
2014-10-14 14:13 ` Tanya Brokhman
2014-10-14 14:16 ` Tanya Brokhman
2014-10-14 14:16 ` Tanya Brokhman
2014-10-14 14:33 ` Joe Perches
2014-10-14 14:33 ` Joe Perches
2014-10-14 15:07 ` Artem Bityutskiy
2014-10-14 15:07 ` Artem Bityutskiy
2014-10-14 16:05 ` Joe Perches
2014-10-14 16:05 ` Joe Perches
2014-10-20 13:51 ` Artem Bityutskiy
2014-10-20 13:51 ` Artem Bityutskiy
2014-10-20 16:54 ` Tanya Brokhman
2014-10-20 16:54 ` Tanya Brokhman
2014-10-20 17:29 ` Joe Perches
2014-10-20 17:29 ` Joe Perches
2014-10-14 14:39 ` Ezequiel Garcia
2014-10-14 14:39 ` Ezequiel Garcia
2014-10-14 15:09 ` Artem Bityutskiy [this message]
2014-10-14 15:09 ` Artem Bityutskiy
2014-10-14 18:47 ` Ezequiel Garcia
2014-10-14 18:47 ` Ezequiel Garcia
2014-10-14 19:13 ` Joe Perches
2014-10-14 19:13 ` Joe Perches
2014-10-14 19:18 ` Ezequiel Garcia
2014-10-14 19:18 ` Ezequiel Garcia
2014-10-14 19:31 ` Joe Perches
2014-10-14 19:31 ` Joe Perches
2014-10-20 13:53 ` Artem Bityutskiy
2014-10-20 13:53 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413299343.7906.103.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.