All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Linus Walleij <linus.walleij@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Lv Zheng <lv.zheng@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	Anton Vorontsov <anton@enomsg.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 0/7] power_supply: Decrement the device reference counter
Date: Wed, 15 Oct 2014 14:52:13 +0200	[thread overview]
Message-ID: <1413377533.26771.16.camel@AMDC1943> (raw)
In-Reply-To: <20141015121841.GA26579@amd>

On śro, 2014-10-15 at 14:18 +0200, Pavel Machek wrote:
> Hi!
> 
> > The reference counter of device allocated for power supply was
> > incremented with each call to power_supply_get_by_name() and
> > power_supply_get_by_phandle().
> > 
> > Add a symmetric 'put' operation so the device could be released after
> > final put_device() call during supply unregistering.
> > 
> > 
> > Rebased on next-20141007 + mine [1] patchset.
> > Tested on Trats2 board (max77693 + charger manager).
> > 
> > Kindly asking for reviewing/testing other drivers.
> 
> I'm not sure if we should support power_supply_put(NULL), but
> otherwise the series looks ok to me.
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

Thanks for reviewing. I'll remove the non-NULL check and resend with
your ack.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] power_supply: Decrement the device reference counter
Date: Wed, 15 Oct 2014 14:52:13 +0200	[thread overview]
Message-ID: <1413377533.26771.16.camel@AMDC1943> (raw)
In-Reply-To: <20141015121841.GA26579@amd>

On ?ro, 2014-10-15 at 14:18 +0200, Pavel Machek wrote:
> Hi!
> 
> > The reference counter of device allocated for power supply was
> > incremented with each call to power_supply_get_by_name() and
> > power_supply_get_by_phandle().
> > 
> > Add a symmetric 'put' operation so the device could be released after
> > final put_device() call during supply unregistering.
> > 
> > 
> > Rebased on next-20141007 + mine [1] patchset.
> > Tested on Trats2 board (max77693 + charger manager).
> > 
> > Kindly asking for reviewing/testing other drivers.
> 
> I'm not sure if we should support power_supply_put(NULL), but
> otherwise the series looks ok to me.
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

Thanks for reviewing. I'll remove the non-NULL check and resend with
your ack.

Best regards,
Krzysztof

  reply	other threads:[~2014-10-15 12:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 12:35 [PATCH 0/7] power_supply: Decrement the device reference counter Krzysztof Kozlowski
2014-10-14 12:35 ` Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 1/7] power_supply: Add power_supply_put for decrementing " Krzysztof Kozlowski
2014-10-14 12:35   ` Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 2/7] power: charger-manager: Decrement the power supply's " Krzysztof Kozlowski
2014-10-14 12:35   ` Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 3/7] x86/olpc/xo1/sci: Use newly added power_supply_put API Krzysztof Kozlowski
2014-10-14 12:35   ` Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 4/7] x86/olpc/xo15/sci: " Krzysztof Kozlowski
2014-10-14 12:35   ` Krzysztof Kozlowski
2014-10-14 12:35   ` Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 5/7] power: 88pm860x_charger: Decrement the power supply's device reference counter Krzysztof Kozlowski
2014-10-14 12:35   ` Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 6/7] power: bq2415x_charger: " Krzysztof Kozlowski
2014-10-14 12:35   ` Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 7/7] mfd: ab8500: " Krzysztof Kozlowski
2014-10-14 12:35   ` Krzysztof Kozlowski
2014-10-28 10:00   ` Linus Walleij
2014-10-28 10:00     ` Linus Walleij
2014-10-28 10:00     ` Linus Walleij
2014-11-03 17:59   ` Lee Jones
2014-11-03 17:59     ` Lee Jones
2014-11-03 18:00     ` Lee Jones
2014-11-03 18:00       ` Lee Jones
2014-11-04  7:50       ` Krzysztof Kozlowski
2014-11-04  7:50         ` Krzysztof Kozlowski
2014-10-15 12:18 ` [PATCH 0/7] power_supply: Decrement the " Pavel Machek
2014-10-15 12:18   ` Pavel Machek
2014-10-15 12:52   ` Krzysztof Kozlowski [this message]
2014-10-15 12:52     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413377533.26771.16.camel@AMDC1943 \
    --to=k.kozlowski@samsung.com \
    --cc=anton@enomsg.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=bhelgaas@google.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kyungmin.park@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=m.szyprowski@samsung.com \
    --cc=mingo@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sameo@linux.intel.com \
    --cc=sre@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.