All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Dmitry Eremin-Solenikov
	<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Kyungmin Park
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Marek Szyprowski
	<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Bartlomiej Zolnierkiewicz
	<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2 2/5] mfd: max77693: Map charger device to its own of_node
Date: Mon, 20 Oct 2014 17:09:41 +0200	[thread overview]
Message-ID: <1413817781.11298.0.camel@AMDC1943> (raw)
In-Reply-To: <20141020150630.GB26784@x1>

On pon, 2014-10-20 at 16:06 +0100, Lee Jones wrote:
> On Mon, 20 Oct 2014, Krzysztof Kozlowski wrote:
> 
> > Add a "maxim,max77693-charger" of_compatible to the mfd_cell so the MFD
> > child device (the charger) will have its own of_node set. This will be
> > used by the max77693 charger driver in next patches to obtain battery
> > configuration from DTS.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > ---
> >  drivers/mfd/max77693.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> > index cf008f45968c..2277a11b6629 100644
> > --- a/drivers/mfd/max77693.c
> > +++ b/drivers/mfd/max77693.c
> > @@ -43,7 +43,10 @@
> >  
> >  static const struct mfd_cell max77693_devs[] = {
> >  	{ .name = "max77693-pmic", },
> > -	{ .name = "max77693-charger", },
> > +	{
> > +		.name = "max77693-charger",
> > +		.of_compatible = "maxim,max77693-charger",
> > +	},
> >  	{ .name = "max77693-muic", },
> >  	{ .name = "max77693-haptic", },
> >  	{
> 
> I'm guessing this can be applied separately?

Yes. Patch 3/5 also (it adds necessary defines and symbols for
chargers).

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-api@vger.kernel.org, devicetree@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 2/5] mfd: max77693: Map charger device to its own of_node
Date: Mon, 20 Oct 2014 17:09:41 +0200	[thread overview]
Message-ID: <1413817781.11298.0.camel@AMDC1943> (raw)
In-Reply-To: <20141020150630.GB26784@x1>

On pon, 2014-10-20 at 16:06 +0100, Lee Jones wrote:
> On Mon, 20 Oct 2014, Krzysztof Kozlowski wrote:
> 
> > Add a "maxim,max77693-charger" of_compatible to the mfd_cell so the MFD
> > child device (the charger) will have its own of_node set. This will be
> > used by the max77693 charger driver in next patches to obtain battery
> > configuration from DTS.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> >  drivers/mfd/max77693.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> > index cf008f45968c..2277a11b6629 100644
> > --- a/drivers/mfd/max77693.c
> > +++ b/drivers/mfd/max77693.c
> > @@ -43,7 +43,10 @@
> >  
> >  static const struct mfd_cell max77693_devs[] = {
> >  	{ .name = "max77693-pmic", },
> > -	{ .name = "max77693-charger", },
> > +	{
> > +		.name = "max77693-charger",
> > +		.of_compatible = "maxim,max77693-charger",
> > +	},
> >  	{ .name = "max77693-muic", },
> >  	{ .name = "max77693-haptic", },
> >  	{
> 
> I'm guessing this can be applied separately?

Yes. Patch 3/5 also (it adds necessary defines and symbols for
chargers).

Best regards,
Krzysztof


  reply	other threads:[~2014-10-20 15:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 12:34 [PATCH v2 0/5] power/mfd: Add max77693 charger driver Krzysztof Kozlowski
2014-10-20 12:34 ` Krzysztof Kozlowski
2014-10-20 12:34 ` [PATCH v2 2/5] mfd: max77693: Map charger device to its own of_node Krzysztof Kozlowski
2014-10-20 15:06   ` Lee Jones
2014-10-20 15:09     ` Krzysztof Kozlowski [this message]
2014-10-20 15:09       ` Krzysztof Kozlowski
2014-10-21 10:17       ` Lee Jones
2014-10-21 10:20         ` Krzysztof Kozlowski
2014-10-21 10:20           ` Krzysztof Kozlowski
2014-10-21 10:27           ` Lee Jones
2014-10-21 10:27             ` Lee Jones
2014-10-21 10:17   ` Lee Jones
2014-10-20 12:34 ` [PATCH v2 3/5] mfd: max77693: Add defines for MAX77693 charger driver Krzysztof Kozlowski
     [not found] ` <1413808489-3524-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-20 12:34   ` [PATCH v2 1/5] devicetree: mfd: max77693: Document new bindings for charger Krzysztof Kozlowski
2014-10-20 12:34     ` Krzysztof Kozlowski
2014-10-20 12:34   ` [PATCH v2 4/5] power: max77693: Add charger driver for Maxim 77693 Krzysztof Kozlowski
2014-10-20 12:34     ` Krzysztof Kozlowski
2014-10-27 18:56     ` Sebastian Reichel
     [not found]       ` <20141027185656.GB18965-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2014-10-28  9:16         ` Krzysztof Kozlowski
2014-10-28  9:16           ` Krzysztof Kozlowski
2014-10-20 12:34 ` [PATCH v2 5/5] Documentation: charger: max77693: Document exported sysfs entry Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413817781.11298.0.camel@AMDC1943 \
    --to=k.kozlowski-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
    --cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.