From: Ian.Campbell@citrix.com (Ian Campbell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] xen/arm: introduce GNTTABOP_cache_flush
Date: Mon, 20 Oct 2014 16:50:11 +0100 [thread overview]
Message-ID: <1413820211.29506.9.camel@citrix.com> (raw)
In-Reply-To: <1412941908-5850-7-git-send-email-stefano.stabellini@eu.citrix.com>
On Fri, 2014-10-10 at 12:51 +0100, Stefano Stabellini wrote:
> Introduce support for new hypercall GNTTABOP_cache_flush.
> Use it to perform cache flashing on pages used for dma when necessary.
>
> If GNTTABOP_cache_flush is supported by the hypervisor, we don't need to
> bounce dma map operations that involve foreign grants and non-coherent
> devices.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> ---
>
> Changes in v4:
> - add comment;
> - avoid bouncing dma map operations that involve foreign grants and
> non-coherent devices if GNTTABOP_cache_flush is provided by Xen.
>
> Changes in v3:
> - fix the cache maintenance op call to match what Linux does natively;
> - update the hypercall interface to match Xen.
>
> Changes in v2:
> - update the hypercall interface to match Xen;
> - call the interface on a single page at a time.
> ---
> arch/arm/xen/mm.c | 41 ++++++++++++++++++++++++++++++-----
> include/xen/interface/grant_table.h | 19 ++++++++++++++++
> 2 files changed, 54 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index 0c2a75a..21db123 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -11,6 +11,7 @@
> #include <linux/swiotlb.h>
>
> #include <xen/xen.h>
> +#include <xen/interface/grant_table.h>
> #include <xen/interface/memory.h>
> #include <xen/swiotlb-xen.h>
>
> @@ -44,6 +45,8 @@ static inline void *kmap_high_get(struct page *page)
> static inline void kunmap_high(struct page *page) {}
> #endif
>
> +static bool hypercall_flush = false;
Would be nice to include the word "cache" (or at least cflush) in this.
> -arch_initcall(xen_mm_init);
> +arch_initcall(xen_mm_init)
I think this is stray?
Acked-by: Ian Campbell <ian.campbell@citrix.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: <xen-devel@lists.xensource.com>, <konrad.wilk@oracle.com>,
<david.vrabel@citrix.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 7/7] xen/arm: introduce GNTTABOP_cache_flush
Date: Mon, 20 Oct 2014 16:50:11 +0100 [thread overview]
Message-ID: <1413820211.29506.9.camel@citrix.com> (raw)
In-Reply-To: <1412941908-5850-7-git-send-email-stefano.stabellini@eu.citrix.com>
On Fri, 2014-10-10 at 12:51 +0100, Stefano Stabellini wrote:
> Introduce support for new hypercall GNTTABOP_cache_flush.
> Use it to perform cache flashing on pages used for dma when necessary.
>
> If GNTTABOP_cache_flush is supported by the hypervisor, we don't need to
> bounce dma map operations that involve foreign grants and non-coherent
> devices.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> ---
>
> Changes in v4:
> - add comment;
> - avoid bouncing dma map operations that involve foreign grants and
> non-coherent devices if GNTTABOP_cache_flush is provided by Xen.
>
> Changes in v3:
> - fix the cache maintenance op call to match what Linux does natively;
> - update the hypercall interface to match Xen.
>
> Changes in v2:
> - update the hypercall interface to match Xen;
> - call the interface on a single page at a time.
> ---
> arch/arm/xen/mm.c | 41 ++++++++++++++++++++++++++++++-----
> include/xen/interface/grant_table.h | 19 ++++++++++++++++
> 2 files changed, 54 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index 0c2a75a..21db123 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -11,6 +11,7 @@
> #include <linux/swiotlb.h>
>
> #include <xen/xen.h>
> +#include <xen/interface/grant_table.h>
> #include <xen/interface/memory.h>
> #include <xen/swiotlb-xen.h>
>
> @@ -44,6 +45,8 @@ static inline void *kmap_high_get(struct page *page)
> static inline void kunmap_high(struct page *page) {}
> #endif
>
> +static bool hypercall_flush = false;
Would be nice to include the word "cache" (or at least cflush) in this.
> -arch_initcall(xen_mm_init);
> +arch_initcall(xen_mm_init)
I think this is stray?
Acked-by: Ian Campbell <ian.campbell@citrix.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
david.vrabel@citrix.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 7/7] xen/arm: introduce GNTTABOP_cache_flush
Date: Mon, 20 Oct 2014 16:50:11 +0100 [thread overview]
Message-ID: <1413820211.29506.9.camel@citrix.com> (raw)
In-Reply-To: <1412941908-5850-7-git-send-email-stefano.stabellini@eu.citrix.com>
On Fri, 2014-10-10 at 12:51 +0100, Stefano Stabellini wrote:
> Introduce support for new hypercall GNTTABOP_cache_flush.
> Use it to perform cache flashing on pages used for dma when necessary.
>
> If GNTTABOP_cache_flush is supported by the hypervisor, we don't need to
> bounce dma map operations that involve foreign grants and non-coherent
> devices.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> ---
>
> Changes in v4:
> - add comment;
> - avoid bouncing dma map operations that involve foreign grants and
> non-coherent devices if GNTTABOP_cache_flush is provided by Xen.
>
> Changes in v3:
> - fix the cache maintenance op call to match what Linux does natively;
> - update the hypercall interface to match Xen.
>
> Changes in v2:
> - update the hypercall interface to match Xen;
> - call the interface on a single page at a time.
> ---
> arch/arm/xen/mm.c | 41 ++++++++++++++++++++++++++++++-----
> include/xen/interface/grant_table.h | 19 ++++++++++++++++
> 2 files changed, 54 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index 0c2a75a..21db123 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -11,6 +11,7 @@
> #include <linux/swiotlb.h>
>
> #include <xen/xen.h>
> +#include <xen/interface/grant_table.h>
> #include <xen/interface/memory.h>
> #include <xen/swiotlb-xen.h>
>
> @@ -44,6 +45,8 @@ static inline void *kmap_high_get(struct page *page)
> static inline void kunmap_high(struct page *page) {}
> #endif
>
> +static bool hypercall_flush = false;
Would be nice to include the word "cache" (or at least cflush) in this.
> -arch_initcall(xen_mm_init);
> +arch_initcall(xen_mm_init)
I think this is stray?
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2014-10-20 15:50 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 11:50 [PATCH v4 0/7] introduce GNTTABOP_cache_flush Stefano Stabellini
2014-10-10 11:50 ` Stefano Stabellini
2014-10-10 11:50 ` Stefano Stabellini
2014-10-10 11:51 ` [PATCH v4 1/7] xen/arm: remove handling of XENFEAT_grant_map_identity Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-20 15:14 ` Ian Campbell
2014-10-20 15:14 ` Ian Campbell
2014-10-20 15:14 ` Ian Campbell
2014-10-10 11:51 ` [PATCH v4 2/7] xen/arm: remove outer_*_range call Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 11:51 ` [PATCH v4 3/7] [RFC] arm/arm64: introduce is_dma_coherent Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 12:07 ` Will Deacon
2014-10-10 12:07 ` Will Deacon
2014-10-10 13:04 ` Stefano Stabellini
2014-10-10 13:04 ` Stefano Stabellini
2014-10-13 11:16 ` Stefano Stabellini
2014-10-13 11:16 ` Stefano Stabellini
2014-10-13 12:57 ` Will Deacon
2014-10-13 12:57 ` Will Deacon
2014-10-13 14:43 ` Stefano Stabellini
2014-10-13 14:43 ` Stefano Stabellini
2014-10-22 16:04 ` Stefano Stabellini
2014-10-22 16:04 ` Stefano Stabellini
2014-10-23 14:22 ` Stefano Stabellini
2014-10-23 14:22 ` Stefano Stabellini
2014-10-24 10:47 ` Catalin Marinas
2014-10-24 10:47 ` Catalin Marinas
2014-10-24 11:39 ` Stefano Stabellini
2014-10-24 11:39 ` Stefano Stabellini
2014-10-24 15:43 ` Catalin Marinas
2014-10-24 15:43 ` Catalin Marinas
2014-10-24 17:01 ` Stefano Stabellini
2014-10-24 17:01 ` Stefano Stabellini
2014-10-24 17:29 ` Stefano Stabellini
2014-10-24 17:29 ` Stefano Stabellini
2014-10-25 13:29 ` Stefano Stabellini
2014-10-25 13:29 ` Stefano Stabellini
2014-10-25 13:29 ` Stefano Stabellini
2014-10-25 15:40 ` Ian Campbell
2014-10-25 15:40 ` Ian Campbell
2014-10-25 15:40 ` Ian Campbell
2014-10-25 16:15 ` Stefano Stabellini
2014-10-25 16:15 ` Stefano Stabellini
2014-10-25 16:15 ` Stefano Stabellini
2014-10-27 11:02 ` [Xen-devel] " David Vrabel
2014-10-27 11:02 ` David Vrabel
2014-10-27 11:02 ` David Vrabel
2014-10-27 15:22 ` Stefano Stabellini
2014-10-27 15:22 ` Stefano Stabellini
2014-10-10 11:51 ` [PATCH v4 4/7] xen/arm: use is_dma_coherent Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-20 15:18 ` Ian Campbell
2014-10-20 15:18 ` Ian Campbell
2014-10-20 15:18 ` Ian Campbell
2014-10-10 11:51 ` [PATCH v4 5/7] xen/arm/arm64: merge xen/mm32.c into xen/mm.c Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-20 15:19 ` Ian Campbell
2014-10-20 15:19 ` Ian Campbell
2014-10-20 15:19 ` Ian Campbell
2014-10-10 11:51 ` [PATCH v4 6/7] xen/arm/arm64: introduce xen_arch_need_swiotlb Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-14 16:03 ` Konrad Rzeszutek Wilk
2014-10-14 16:03 ` Konrad Rzeszutek Wilk
2014-10-14 16:12 ` David Vrabel
2014-10-14 16:12 ` David Vrabel
2014-10-14 16:12 ` David Vrabel
2014-10-14 16:21 ` Konrad Rzeszutek Wilk
2014-10-14 16:21 ` Konrad Rzeszutek Wilk
2014-10-10 11:51 ` [PATCH v4 7/7] xen/arm: introduce GNTTABOP_cache_flush Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-10 11:51 ` Stefano Stabellini
2014-10-20 15:50 ` Ian Campbell [this message]
2014-10-20 15:50 ` Ian Campbell
2014-10-20 15:50 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413820211.29506.9.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.