From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Robin Gong <b38343@freescale.com>
Cc: vinod.koul@intel.com, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dma: imx-sdma: correct print format
Date: Tue, 21 Oct 2014 12:38:09 +0300 [thread overview]
Message-ID: <1413884289.2396.22.camel@linux.intel.com> (raw)
In-Reply-To: <1413853781-18384-3-git-send-email-b38343@freescale.com>
On Tue, 2014-10-21 at 09:09 +0800, Robin Gong wrote:
> correct print format for 'size_t', 'dma_address_t',etc.
Ah, okay, you may disregard few of my comments to previous patch.
But here, please, fix the style of commit message (spaces, capital
letters, etc).
>
> Signed-off-by: Robin Gong <b38343@freescale.com>
> ---
> drivers/dma/imx-sdma.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index fc4a0df..7e8aa2d 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1041,7 +1041,7 @@ static struct dma_async_tx_descriptor *sdma_prep_memcpy(
> return NULL;
>
> if (len >= NUM_BD * SDMA_BD_MAX_CNT) {
> - dev_err(sdma->dev, "channel%d: maximum bytes exceeded:%d > %d\n"
> + dev_err(sdma->dev, "channel%d: maximum bytes exceeded:%zu > %d\n"
> , channel, len, NUM_BD * SDMA_BD_MAX_CNT);
> goto err_out;
> }
> @@ -1050,8 +1050,8 @@ static struct dma_async_tx_descriptor *sdma_prep_memcpy(
>
> sdmac->buf_tail = 0;
>
> - dev_dbg(sdma->dev, "memcpy: %x->%x, len=%d, channel=%d.\n",
> - dma_src, dma_dst, len, channel);
> + dev_dbg(sdma->dev, "memcpy: %pad->%pad, len=%zu, channel=%d.\n",
> + &dma_src, &dma_dst, len, channel);
>
> sdmac->direction = DMA_MEM_TO_MEM;
>
> @@ -1104,7 +1104,7 @@ static struct dma_async_tx_descriptor *sdma_prep_memcpy(
> param &= ~BD_CONT;
> }
>
> - dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%08x %s%s\n",
> + dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%u %s%s\n",
> i, count, bd->buffer_addr,
> param & BD_WRAP ? "wrap" : "",
> param & BD_INTR ? " intr" : "");
> @@ -1220,8 +1220,8 @@ static struct dma_async_tx_descriptor *sdma_prep_sg(
> param &= ~BD_CONT;
> }
>
> - dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%08x %s%s\n",
> - i, count, sg_src->dma_address,
> + dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%pad %s%s\n",
> + i, count, &sg_src->dma_address,
> param & BD_WRAP ? "wrap" : "",
> param & BD_INTR ? " intr" : "");
>
> @@ -1291,7 +1291,7 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
> }
>
> if (period_len > SDMA_BD_MAX_CNT) {
> - dev_err(sdma->dev, "SDMA channel %d: maximum period size exceeded: %d > %d\n",
> + dev_err(sdma->dev, "SDMA channel %d: maximum period size exceeded: %zu > %d\n",
> channel, period_len, SDMA_BD_MAX_CNT);
> goto err_out;
> }
> @@ -1315,8 +1315,8 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
> if (i + 1 == num_periods)
> param |= BD_WRAP;
>
> - dev_dbg(sdma->dev, "entry %d: count: %d dma: %#llx %s%s\n",
> - i, period_len, (u64)dma_addr,
> + dev_dbg(sdma->dev, "entry %d: count: %d dma: %pad %s%s\n",
> + i, period_len, &dma_addr,
> param & BD_WRAP ? "wrap" : "",
> param & BD_INTR ? " intr" : "");
>
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2014-10-21 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 1:09 [PATCH v4 0/3] dma: imx-sdma: add support for sdma memory copy Robin Gong
2014-10-21 1:09 ` [PATCH v4 1/3] " Robin Gong
2014-10-21 9:35 ` Andy Shevchenko
2014-10-21 1:09 ` [PATCH v4 2/3] dma: imx-sdma: correct print format Robin Gong
2014-10-21 9:38 ` Andy Shevchenko [this message]
2014-10-21 1:09 ` [PATCH v4 3/3] dma: imx-sdma: reorg code to make code clean Robin Gong
2014-10-21 9:39 ` Andy Shevchenko
2014-10-22 5:42 ` Robin Gong
-- strict thread matches above, loose matches on Subject: below --
2014-10-23 2:19 [PATCH v5 0/3] dma: imx-sdma: add support for sdma memory copy Robin Gong
2014-10-23 2:19 ` [PATCH v4 2/3] dma: imx-sdma: correct print format Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413884289.2396.22.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=b38343@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.