[PATCH] tools/libxl: Fix libxl_list_vcpu() following c/s 93e52d52

[PATCH] tools/libxl: Fix libxl_list_vcpu() following c/s 93e52d52

[Andrew Cooper]

My reasoning regarding nr_cpus_out was wrong, as I had confused nr_cpus_out
with nr_vcpus_out.

Dario pointed this out, but the patch (having gained appropriate acks) got
committed before I could post a correction.

Noticed-by: Dario Faggioli <dario.faggioli@citrix.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
 tools/libxl/libxl.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index ee127d8..18561fb 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -5252,6 +5252,7 @@ libxl_vcpuinfo *libxl_list_vcpu(libxl_ctx *ctx, uint32_t domid,
         return NULL;
     }
 
+    *nr_cpus_out = libxl_get_max_cpus(ctx);
     ret = ptr = libxl__calloc(NOGC, domaininfo.max_vcpu_id + 1,
                               sizeof(libxl_vcpuinfo));
 
-- 
1.7.10.4

Re: [PATCH] tools/libxl: Fix libxl_list_vcpu() following c/s 93e52d52

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 889 bytes --]

On Thu, 2014-10-23 at 12:01 +0100, Andrew Cooper wrote:
> My reasoning regarding nr_cpus_out was wrong, as I had confused nr_cpus_out
> with nr_vcpus_out.
> 
> Dario pointed this out, but the patch (having gained appropriate acks) got
> committed before I could post a correction.
> 
:-)

> Noticed-by: Dario Faggioli <dario.faggioli@citrix.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] tools/libxl: Fix libxl_list_vcpu() following c/s 93e52d52

[Ian Campbell]

On Thu, 2014-10-23 at 13:08 +0200, Dario Faggioli wrote:
> On Thu, 2014-10-23 at 12:01 +0100, Andrew Cooper wrote:
> > My reasoning regarding nr_cpus_out was wrong, as I had confused nr_cpus_out
> > with nr_vcpus_out.
> > 
> > Dario pointed this out, but the patch (having gained appropriate acks) got
> > committed before I could post a correction.
> > 
> :-)
> 
> > Noticed-by: Dario Faggioli <dario.faggioli@citrix.com>
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > CC: Ian Campbell <Ian.Campbell@citrix.com>
> > CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> >
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Acked + applied.
> 
> Regards,
> Dario
>