From: Ian Campbell <Ian.Campbell@citrix.com>
To: Roy Franz <roy.franz@linaro.org>
Cc: tim@xen.org, stefano.stabellini@citrix.com, fu.wei@linaro.org,
jbeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.5] EFI: Always use EFI command line
Date: Fri, 24 Oct 2014 07:43:45 +0100 [thread overview]
Message-ID: <1414133025.20604.89.camel@citrix.com> (raw)
In-Reply-To: <1414109782-22961-1-git-send-email-roy.franz@linaro.org>
On Thu, 2014-10-23 at 17:16 -0700, Roy Franz wrote:
> This patch changes the ARM EFI boot code to always use the EFI commandline,
> even when loaded by GRUB, which makes it consistent with Linux EFI booting.
> The code previously incorrectly skipped processing of the EFI command line when
> modules are present in the loader supplied FDT and the config file is not used.
> There is no change in behavior for x86 since it unconditionally uses the config
> file.
>
> Signed-off-by: Roy Franz <roy.franz@linaro.org>
Please can you update whichever of the docs are relevant as part of this
patch i.e. One or more of misc/arm/booting.txt,
misc/arm/device-tree/booting.txt or misc/efi.markdown might plausibly
need updates to describe the new precedence for where a command line
will be taken from.
http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot will also need updating at some point.
How does this interact with the presence/absence of a config file and
any potential options= in that?
What about the "efi options" like "-cfg=" which are currently handled
from the UEFI command line, are they still correctly handled? (looks
like the others are -help and -basevideo)
Ian.
next prev parent reply other threads:[~2014-10-24 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 0:16 [PATCH for-4.5] EFI: Always use EFI command line Roy Franz
2014-10-24 6:43 ` Ian Campbell [this message]
2014-10-24 22:01 ` Roy Franz
2014-10-24 10:48 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414133025.20604.89.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=fu.wei@linaro.org \
--cc=jbeulich@suse.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.