From: Joe Perches <joe@perches.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [patch] ath9k: fix some debugfs output
Date: Wed, 29 Oct 2014 09:13:24 -0700 [thread overview]
Message-ID: <1414599204.11707.5.camel@perches.com> (raw)
In-Reply-To: <20141029161021.GH6890@mwanda>
On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote:
> On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote:
> > On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote:
> > > The right shift operation has higher precedence than the mask so we
> > > left shift by "(i * 3)" and then immediately right shift by "(i * 3)"
> > > then we mask. It should be left shift, mask, and then right shift.
[]
> > My grep pattern doesn't like operations on the thing masked.
> > Did you find this by some tool or visual inspection via grep?
[]
> I wrote a Smatch check inspired by the i40e bug you found earlier.
Nice. fyi: I sent a bunch of these already.
https://lkml.org/lkml/2014/10/27/38
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ath9k: fix some debugfs output
Date: Wed, 29 Oct 2014 16:13:24 +0000 [thread overview]
Message-ID: <1414599204.11707.5.camel@perches.com> (raw)
In-Reply-To: <20141029161021.GH6890@mwanda>
On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote:
> On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote:
> > On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote:
> > > The right shift operation has higher precedence than the mask so we
> > > left shift by "(i * 3)" and then immediately right shift by "(i * 3)"
> > > then we mask. It should be left shift, mask, and then right shift.
[]
> > My grep pattern doesn't like operations on the thing masked.
> > Did you find this by some tool or visual inspection via grep?
[]
> I wrote a Smatch check inspired by the i40e bug you found earlier.
Nice. fyi: I sent a bunch of these already.
https://lkml.org/lkml/2014/10/27/38
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ath9k: fix some debugfs output
Date: Wed, 29 Oct 2014 09:13:24 -0700 [thread overview]
Message-ID: <1414599204.11707.5.camel@perches.com> (raw)
In-Reply-To: <20141029161021.GH6890@mwanda>
On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote:
> On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote:
> > On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote:
> > > The right shift operation has higher precedence than the mask so we
> > > left shift by "(i * 3)" and then immediately right shift by "(i * 3)"
> > > then we mask. It should be left shift, mask, and then right shift.
[]
> > My grep pattern doesn't like operations on the thing masked.
> > Did you find this by some tool or visual inspection via grep?
[]
> I wrote a Smatch check inspired by the i40e bug you found earlier.
Nice. fyi: I sent a bunch of these already.
https://lkml.org/lkml/2014/10/27/38
next prev parent reply other threads:[~2014-10-29 16:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 15:48 [ath9k-devel] [patch] ath9k: fix some debugfs output Dan Carpenter
2014-10-29 15:48 ` Dan Carpenter
2014-10-29 15:48 ` Dan Carpenter
2014-10-29 16:08 ` [ath9k-devel] " Joe Perches
2014-10-29 16:08 ` Joe Perches
2014-10-29 16:08 ` Joe Perches
2014-10-29 16:10 ` [ath9k-devel] " Dan Carpenter
2014-10-29 16:10 ` Dan Carpenter
2014-10-29 16:10 ` Dan Carpenter
2014-10-29 16:13 ` Joe Perches [this message]
2014-10-29 16:13 ` Joe Perches
2014-10-29 16:13 ` Joe Perches
2014-10-29 18:53 ` [ath9k-devel] " Dan Carpenter
2014-10-29 18:53 ` Dan Carpenter
2014-10-29 18:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414599204.11707.5.camel@perches.com \
--to=joe@perches.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.