Re: [PATCH for-4.5] xen/common: Process softirqs while dumping domains

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1225 bytes --]

On Wed, 2014-10-29 at 15:08 +0000, Andrew Cooper wrote:
> Process softirqs once per domain, and once every 64 vcpus in a guest to avoid
> being hit by the NMI watchdog.  Discovered against a VM which had accidentally
> been assigned 8192 vcpus.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Personally...

> diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
> index 809378c..c9d9206 100644
> --- a/xen/common/keyhandler.c
> +++ b/xen/common/keyhandler.c

> @@ -287,6 +290,9 @@ static void dump_domains(unsigned char key)
>                 d->domain_id);
>          for_each_vcpu ( d, v )
>          {
> +            if ( (v->vcpu_id & 0x3f) == 0 )
> +                process_pending_softirqs();
> +
>
... I think something like ( vcpu_id % 64 ) would have been more
readable, but I understand that's only a matter of taste. :-)

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel