All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: hujianyang <hujianyang@huawei.com>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Bill Pringlemeir <bpringlemeir@nbsps.com>
Subject: Re: [PATCH v5 3/4] ubi-utils: ubidump: introduce ubidump
Date: Thu, 30 Oct 2014 10:30:28 +0200	[thread overview]
Message-ID: <1414657828.23185.16.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1414657165.23185.10.camel@sauron.fi.intel.com>

On Thu, 2014-10-30 at 10:19 +0200, Artem Bityutskiy wrote:
> On Wed, 2014-10-22 at 18:43 +0800, hujianyang wrote:
> > +static const char optionsstr[] =
> > +"-h, --help            print help message\n"
> > +"-l, --lnum            logic eraseblock num to dump\n"
> > +"-i, --info            show explicit information about ubifs-level\n"
> 
> So what does this '-i' option do? I cannot grasp this from the comment.

Ok, I think I see what you mean here. This is about dumping UBIFS data
in addition to the UBI data.

First of all, let's re-phrase this. Do not use word "explicit", it does
not seem to bear any useful meaning here. Just say "also dump UBIFS
nodes" or something like this.

And "-i" / "--info" are not the best names, I think. "-u" / "--ubifs"
would be better.

And regarding the -l option. What if I do not specify it? What will be
dumped? Everything? Nothing? I'd vote for duping everything (all LEBs).

Artem.

  reply	other threads:[~2014-10-30  8:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 10:37 [PATCH v5 1/4] ubi-utils: ubidump: add ubifs-media hujianyang
2014-10-22 10:40 ` [PATCH v5 2/4] ubi-utils: ubidump: add libdump hujianyang
2014-10-22 10:43 ` [PATCH v5 3/4] ubi-utils: ubidump: introduce ubidump hujianyang
2014-10-30  8:19   ` Artem Bityutskiy
2014-10-30  8:30     ` Artem Bityutskiy [this message]
2014-10-31  2:17       ` hujianyang
2014-10-31  7:32         ` Artem Bityutskiy
2014-10-31 10:55           ` hujianyang
2014-10-31 13:20             ` Artem Bityutskiy
2014-11-20  9:24               ` hujianyang
2014-11-27 14:32                 ` Artem Bityutskiy
2014-12-01  1:45                   ` hujianyang
2014-10-22 10:47 ` [PATCH v5 4/4] ubi-utils: ubidump: compile enable hujianyang
2014-10-30  7:51 ` [PATCH v5 1/4] ubi-utils: ubidump: add ubifs-media Artem Bityutskiy
2014-10-30  8:01 ` Artem Bityutskiy
2014-10-31  2:03   ` hujianyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414657828.23185.16.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=bpringlemeir@nbsps.com \
    --cc=hujianyang@huawei.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.