Re: [PATCH v5 3/4] ubi-utils: ubidump: introduce ubidump

[hujianyang <hujianyang@huawei.com>]

On 2014/10/31 15:32, Artem Bityutskiy wrote:
> On Fri, 2014-10-31 at 10:17 +0800, hujianyang wrote:
>>>
>>> And "-i" / "--info" are not the best names, I think. "-u" / "--ubifs"
>>> would be better.
>>>
>>
>> Oh, I'd like to reserve this "--ubifs" when we are ready to dump ubi-level
>> stuff. So in my previous design, "--ubifs" and "--ubi" are used to indicate
>> only dump the specific area of an eraseblock.
>>
>> How about an option like "--node" ? Do you insist on "--ubifs" or have
>> another suggestion?
> 
> The idea is that you introduce an option, and then you do not change
> it's name. So the name should be informative. What is more informative
> for "also dump ubifs nodes": --node or --ubifs ?
> 
> You can always add --ubi later.
> 
> For now, if --ubifs is not specified, you should do basically nothing,
> because you cannot dump UBI right now.
> 
> Does this make sense for you?
> 
> Artem.
> 
> 
> 

I should say it is unfair for me to discuss a problem like this with
you. I will follow your idea because I not good at English.

Give me some days, I will resend this patch set. I'm happy to see the
patch set is thinner than it used to be. Thanks for your help.

Happy Halloween:)

Hu