From: Vivien Didelot <vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org
Subject: Re: [PATCH] misc: (at24) move header to linux/platform_data/
Date: Thu, 26 Sep 2013 16:09:12 -0400 (EDT) [thread overview]
Message-ID: <1414767040.1054326.1380226152008.JavaMail.root@mail> (raw)
In-Reply-To: <169123028.921974.1377290733515.JavaMail.root@mail>
Hi Wolfram,
> Wolfram wrote:
>
> > > IMHO it makes sense. Why wouldn't we want all platform_data in
> > > include/linux/platform_data/?
> >
> > For the same reason we don't want all driver source files in one
> > directory? It's a mess.
>
> Well, that's different. Not all drivers expose platform data, but
> many subsystems have drivers with platform data. A common include
> directory for the *_platform_data structure definitions makes sense.
Also IMO having such header file in include/linux/i2c/ for a driver
declared in drivers/misc/eeprom/ is not very consistent.
So this is the purpose of this include directory. What do you think?
Best,
Vivien
WARNING: multiple messages have this Message-ID (diff)
From: vivien.didelot@savoirfairelinux.com (Vivien Didelot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] misc: (at24) move header to linux/platform_data/
Date: Thu, 26 Sep 2013 16:09:12 -0400 (EDT) [thread overview]
Message-ID: <1414767040.1054326.1380226152008.JavaMail.root@mail> (raw)
In-Reply-To: <169123028.921974.1377290733515.JavaMail.root@mail>
Hi Wolfram,
> Wolfram wrote:
>
> > > IMHO it makes sense. Why wouldn't we want all platform_data in
> > > include/linux/platform_data/?
> >
> > For the same reason we don't want all driver source files in one
> > directory? It's a mess.
>
> Well, that's different. Not all drivers expose platform data, but
> many subsystems have drivers with platform data. A common include
> directory for the *_platform_data structure definitions makes sense.
Also IMO having such header file in include/linux/i2c/ for a driver
declared in drivers/misc/eeprom/ is not very consistent.
So this is the purpose of this include directory. What do you think?
Best,
Vivien
WARNING: multiple messages have this Message-ID (diff)
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH] misc: (at24) move header to linux/platform_data/
Date: Thu, 26 Sep 2013 16:09:12 -0400 (EDT) [thread overview]
Message-ID: <1414767040.1054326.1380226152008.JavaMail.root@mail> (raw)
In-Reply-To: <169123028.921974.1377290733515.JavaMail.root@mail>
Hi Wolfram,
> Wolfram wrote:
>
> > > IMHO it makes sense. Why wouldn't we want all platform_data in
> > > include/linux/platform_data/?
> >
> > For the same reason we don't want all driver source files in one
> > directory? It's a mess.
>
> Well, that's different. Not all drivers expose platform data, but
> many subsystems have drivers with platform data. A common include
> directory for the *_platform_data structure definitions makes sense.
Also IMO having such header file in include/linux/i2c/ for a driver
declared in drivers/misc/eeprom/ is not very consistent.
So this is the purpose of this include directory. What do you think?
Best,
Vivien
next prev parent reply other threads:[~2013-09-26 20:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 18:38 [PATCH] misc: (at24) move header to linux/platform_data/ Vivien Didelot
2013-08-23 18:38 ` Vivien Didelot
2013-08-23 18:38 ` Vivien Didelot
2013-08-23 19:02 ` Wolfram Sang
2013-08-23 19:02 ` Wolfram Sang
2013-08-23 19:19 ` Vivien Didelot
2013-08-23 19:19 ` Vivien Didelot
2013-08-23 19:19 ` Vivien Didelot
2013-08-23 19:26 ` Alexander Shiyan
2013-08-23 19:26 ` Alexander Shiyan
2013-08-23 19:26 ` Alexander Shiyan
2013-08-23 19:40 ` Vivien Didelot
2013-08-23 19:40 ` Vivien Didelot
2013-08-23 20:11 ` Wolfram Sang
2013-08-23 20:11 ` Wolfram Sang
2013-08-23 20:11 ` Wolfram Sang
2013-08-23 20:45 ` Vivien Didelot
2013-08-23 20:45 ` Vivien Didelot
2013-08-23 20:45 ` Vivien Didelot
2013-09-26 20:09 ` Vivien Didelot [this message]
2013-09-26 20:09 ` Vivien Didelot
2013-09-26 20:09 ` Vivien Didelot
2013-09-27 16:32 ` Wolfram Sang
2013-09-27 16:32 ` Wolfram Sang
2013-09-27 16:32 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414767040.1054326.1380226152008.JavaMail.root@mail \
--to=vivien.didelot-4ysuxcep3am1wj+d4i0nrvatqe2ktcn/@public.gmane.org \
--cc=kernel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.