From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v3 08/14] mfd: max77686/802: Remove support for board files
Date: Tue, 04 Nov 2014 08:51:50 +0100 [thread overview]
Message-ID: <1415087510.2389.4.camel@AMDC1943> (raw)
In-Reply-To: <20141103170128.GD12011@x1>
On pon, 2014-11-03 at 17:01 +0000, Lee Jones wrote:
> On Thu, 30 Oct 2014, Krzysztof Kozlowski wrote:
>
> > The driver is used only on Exynos based boards with DTS support.
> > Convert the driver to DTS-only version. This simplifies a little the
> > code:
> > 1. No dead (unused) entries in platform_data structure.
> > 2. More code removed.
> > 3. Regulator driver does not depend on allocated memory
> > from MFD driver.
> > 4. It makes also easier extending the regulator driver.
> >
> > Add to the max77686 MFD driver dependency on CONFIG_OF because without
> > DTS the regulator drivers won't bind.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> > ---
> > drivers/mfd/Kconfig | 1 +
> > drivers/mfd/max77686.c | 23 -----------------------
> > include/linux/mfd/max77686-private.h | 1 -
> > include/linux/mfd/max77686.h | 28 ----------------------------
> > 4 files changed, 1 insertion(+), 52 deletions(-)
>
> Applied, thanks.
Noooo, don't apply it. It depends on previous patches removing the board
file support from regulators.
If the patch looks OK, please only ack it. I would like to push
everything through regulator tree.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 08/14] mfd: max77686/802: Remove support for board files
Date: Tue, 04 Nov 2014 08:51:50 +0100 [thread overview]
Message-ID: <1415087510.2389.4.camel@AMDC1943> (raw)
In-Reply-To: <20141103170128.GD12011@x1>
On pon, 2014-11-03 at 17:01 +0000, Lee Jones wrote:
> On Thu, 30 Oct 2014, Krzysztof Kozlowski wrote:
>
> > The driver is used only on Exynos based boards with DTS support.
> > Convert the driver to DTS-only version. This simplifies a little the
> > code:
> > 1. No dead (unused) entries in platform_data structure.
> > 2. More code removed.
> > 3. Regulator driver does not depend on allocated memory
> > from MFD driver.
> > 4. It makes also easier extending the regulator driver.
> >
> > Add to the max77686 MFD driver dependency on CONFIG_OF because without
> > DTS the regulator drivers won't bind.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> > ---
> > drivers/mfd/Kconfig | 1 +
> > drivers/mfd/max77686.c | 23 -----------------------
> > include/linux/mfd/max77686-private.h | 1 -
> > include/linux/mfd/max77686.h | 28 ----------------------------
> > 4 files changed, 1 insertion(+), 52 deletions(-)
>
> Applied, thanks.
Noooo, don't apply it. It depends on previous patches removing the board
file support from regulators.
If the patch looks OK, please only ack it. I would like to push
everything through regulator tree.
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-11-04 7:51 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 11:20 [PATCH v3 00/14] regulator: max77686: Add GPIO control Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [PATCH v3 01/14] mfd: max77686/802: Map regulator driver to its own of_node Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-31 12:23 ` Mark Brown
2014-10-31 12:23 ` Mark Brown
2014-10-31 13:07 ` Krzysztof Kozlowski
2014-10-31 13:07 ` Krzysztof Kozlowski
2014-10-31 18:06 ` Mark Brown
2014-10-31 18:06 ` Mark Brown
2014-10-30 11:20 ` [PATCH v3 02/14] mfd/regulator: dt-bindings: max77686: Document of_compatible for regulator Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-11-03 17:00 ` Lee Jones
2014-11-03 17:00 ` Lee Jones
2014-11-04 7:53 ` Krzysztof Kozlowski
2014-11-04 7:53 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [PATCH v3 03/14] regulator: dt-bindings: max77802: " Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [PATCH v3 04/14] regulator: max77686: Consistently index opmode array by rdev id Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [RFT v3 05/14] regulator: max77802: Don't ignore return value of current opmode Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
[not found] ` <1414668053-31370-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-30 11:42 ` Javier Martinez Canillas
2014-10-30 11:42 ` Javier Martinez Canillas
2014-10-30 11:42 ` Javier Martinez Canillas
2014-10-30 11:20 ` [RFT v3 06/14] regulator: max77802: Remove support for board files Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
[not found] ` <1414668053-31370-7-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-30 11:50 ` Javier Martinez Canillas
2014-10-30 11:50 ` Javier Martinez Canillas
2014-10-30 11:50 ` Javier Martinez Canillas
2014-10-30 12:10 ` Krzysztof Kozlowski
2014-10-30 12:10 ` Krzysztof Kozlowski
2014-10-30 12:21 ` Javier Martinez Canillas
2014-10-30 12:21 ` Javier Martinez Canillas
2014-10-30 12:30 ` Krzysztof Kozlowski
2014-10-30 12:30 ` Krzysztof Kozlowski
2014-10-30 12:42 ` Javier Martinez Canillas
2014-10-30 12:42 ` Javier Martinez Canillas
2014-10-30 12:53 ` Krzysztof Kozlowski
2014-10-30 12:53 ` Krzysztof Kozlowski
2014-10-30 14:02 ` Javier Martinez Canillas
2014-10-30 14:02 ` Javier Martinez Canillas
2014-10-30 11:20 ` [PATCH v3 07/14] regulator: max77686: " Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [PATCH v3 08/14] mfd: max77686/802: " Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-11-03 17:01 ` Lee Jones
2014-11-03 17:01 ` Lee Jones
2014-11-04 7:51 ` Krzysztof Kozlowski [this message]
2014-11-04 7:51 ` Krzysztof Kozlowski
2014-11-04 8:07 ` Lee Jones
2014-11-04 8:07 ` Lee Jones
2014-10-30 11:20 ` [PATCH v3 09/14] regulator: max77686: Initialize opmode explicitly to normal mode Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [PATCH v3 10/14] regulator: max77686: Add GPIO control Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [PATCH v3 11/14] mfd/regulator: dt-bindings: max77686: Document gpio properties Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [PATCH v3 12/14] ARM: dts: exynos4412-trats: Switch max77686 regulators to GPIO control Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` [PATCH v3 13/14] ARM: dts: exynos5420-peach: Update to new max77802 regulator compatible Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
[not found] ` <1414668053-31370-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-30 11:20 ` [PATCH v3 14/14] ARM: dts: exynos5800-peach: " Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
2014-10-30 11:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415087510.2389.4.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.