All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mahendran Ganesh <opensource.ganesh@gmail.com>
To: sjennings@variantweb.net, minchan@kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Mahendran Ganesh <opensource.ganesh@gmail.com>
Subject: [PATCH] mm/zswap: unregister zswap_cpu_notifier_block in cleanup procedure
Date: Sun,  9 Nov 2014 19:22:23 +0800	[thread overview]
Message-ID: <1415532143-4409-1-git-send-email-opensource.ganesh@gmail.com> (raw)

In zswap_cpu_init(), the code does not unregister *zswap_cpu_notifier_block*
during the cleanup procedure.

This patch fix this issue.

Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
---
 mm/zswap.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/zswap.c b/mm/zswap.c
index ea064c1..51a2c45 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -404,6 +404,7 @@ static int zswap_cpu_init(void)
 cleanup:
 	for_each_online_cpu(cpu)
 		__zswap_cpu_notifier(CPU_UP_CANCELED, cpu);
+	__unregister_cpu_notifier(&zswap_cpu_notifier_block);
 	cpu_notifier_register_done();
 	return -ENOMEM;
 }
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mahendran Ganesh <opensource.ganesh@gmail.com>
To: sjennings@variantweb.net, minchan@kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Mahendran Ganesh <opensource.ganesh@gmail.com>
Subject: [PATCH] mm/zswap: unregister zswap_cpu_notifier_block in cleanup procedure
Date: Sun,  9 Nov 2014 19:22:23 +0800	[thread overview]
Message-ID: <1415532143-4409-1-git-send-email-opensource.ganesh@gmail.com> (raw)

In zswap_cpu_init(), the code does not unregister *zswap_cpu_notifier_block*
during the cleanup procedure.

This patch fix this issue.

Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
---
 mm/zswap.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/zswap.c b/mm/zswap.c
index ea064c1..51a2c45 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -404,6 +404,7 @@ static int zswap_cpu_init(void)
 cleanup:
 	for_each_online_cpu(cpu)
 		__zswap_cpu_notifier(CPU_UP_CANCELED, cpu);
+	__unregister_cpu_notifier(&zswap_cpu_notifier_block);
 	cpu_notifier_register_done();
 	return -ENOMEM;
 }
-- 
1.7.9.5


             reply	other threads:[~2014-11-09 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-09 11:22 Mahendran Ganesh [this message]
2014-11-09 11:22 ` [PATCH] mm/zswap: unregister zswap_cpu_notifier_block in cleanup procedure Mahendran Ganesh
2014-11-13  2:53 ` Seth Jennings
2014-11-13  2:53   ` Seth Jennings
2014-11-13 13:55   ` Ganesh Mahendran
2014-11-13 13:55     ` Ganesh Mahendran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415532143-4409-1-git-send-email-opensource.ganesh@gmail.com \
    --to=opensource.ganesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=sjennings@variantweb.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.