All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Meng Xu <xumengpanda@gmail.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Meng Xu <mengxu@cis.upenn.edu>, Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH for Xen 4.5 v2 2/2] xen: serialize vcpu data in sched_rt.c
Date: Mon, 10 Nov 2014 16:36:59 +0100	[thread overview]
Message-ID: <1415633819.3717.43.camel@Abyss> (raw)
In-Reply-To: <CAENZ-+ky2ZQGhHfyCJe2Yy+eVJqCfo-RQLxD-dDLJ=xoqUP9Sg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 962 bytes --]

On Mon, 2014-11-10 at 10:29 -0500, Meng Xu wrote:
> I'm not sure if I should resend the patch just to change the commit
> log and add the reason of why doing this. 
> 
Yes, that is usually quite a good reason, as changelogs are really
important (for the reasons George pointed out already).

Sometimes, maintainers and committers do the edits themselves (after
asking or at least informing the mailing list), but this only happens
for minor and not substantial modifications.

In this case, the most correct thing is that you resend.


> George, if I should resend the patch set, please let me know.
> 
I'm not George but, yes, please, do resend. :-)

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2014-11-10 15:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-25 14:16 Sanity check input and serialize vcpu data in sched_rt.c Meng Xu
2014-10-25 14:16 ` [PATCH for Xen 4.5 v2 1/2] xen: sanity check input and serialization " Meng Xu
2014-10-29  9:41   ` Dario Faggioli
2014-10-29 14:27     ` Meng Xu
2014-11-10 12:54   ` George Dunlap
2014-10-25 14:16 ` [PATCH for Xen 4.5 v2 2/2] xen: serialize vcpu data " Meng Xu
2014-10-29  9:26   ` Dario Faggioli
2014-11-10 12:53   ` George Dunlap
2014-11-10 15:29     ` Meng Xu
2014-11-10 15:36       ` Dario Faggioli [this message]
2014-11-10 15:38         ` George Dunlap
2014-11-10 15:40       ` George Dunlap
2014-11-10 16:04         ` Meng Xu
2014-11-10 16:15           ` George Dunlap
2014-10-29 10:06 ` Sanity check input and " Dario Faggioli
2014-10-29 14:23   ` Meng Xu
2014-10-29 17:52     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415633819.3717.43.camel@Abyss \
    --to=dario.faggioli@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=mengxu@cis.upenn.edu \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=xumengpanda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.