From: George Dunlap <george.dunlap@eu.citrix.com>
To: Meng Xu <xumengpanda@gmail.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Meng Xu <mengxu@cis.upenn.edu>, Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH for Xen 4.5 v2 2/2] xen: serialize vcpu data in sched_rt.c
Date: Mon, 10 Nov 2014 16:15:22 +0000 [thread overview]
Message-ID: <5460E49A.5020000@eu.citrix.com> (raw)
In-Reply-To: <CAENZ-+=-9VK7D+=nNdM+PP3OmJQmS=CDWKPQ6_uXzNG1qiHdxg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1274 bytes --]
On 11/10/2014 04:04 PM, Meng Xu wrote:
>
>
> 2014-11-10 10:40 GMT-05:00 George Dunlap <george.dunlap@eu.citrix.com
> <mailto:george.dunlap@eu.citrix.com>>:
>
> On 11/10/2014 03:29 PM, Meng Xu wrote:
>> I'm not sure if I should resend the patch just to change the
>> commit log and add the reason of why doing this.
>>
>> I want to first add the reason. If I should resend the patch set,
>> please let me know.
>>
>> 2014-11-10 7:53 GMT-05:00 George Dunlap
>> <george.dunlap@eu.citrix.com <mailto:george.dunlap@eu.citrix.com>>:
>>
>> On 10/25/2014 03:16 PM, Meng Xu wrote:
>>
>> Move call to rt_update_deadline from _alloc to _insert;
>>
>>
>> The runq queue lock is not grabbed when rt_update_deadline is
>> called in rt_alloc_vdata function, which may cause race condition.
>
> Can you not grab the lock in rt_alloc_vdata?
>
>
> Yes. Because when we allocate a rt_vcpu, only one cpu will do that.
> In addition, before the rt_vcpu is inserted into the runq, we won't
> have more than one cpu operate on this rt_vcpu.
Right, well that's important information to help someone reading the
patch understand what's going on.
Thanks for being flexible. :-)
-George
[-- Attachment #1.2: Type: text/html, Size: 4458 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-11-10 16:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 14:16 Sanity check input and serialize vcpu data in sched_rt.c Meng Xu
2014-10-25 14:16 ` [PATCH for Xen 4.5 v2 1/2] xen: sanity check input and serialization " Meng Xu
2014-10-29 9:41 ` Dario Faggioli
2014-10-29 14:27 ` Meng Xu
2014-11-10 12:54 ` George Dunlap
2014-10-25 14:16 ` [PATCH for Xen 4.5 v2 2/2] xen: serialize vcpu data " Meng Xu
2014-10-29 9:26 ` Dario Faggioli
2014-11-10 12:53 ` George Dunlap
2014-11-10 15:29 ` Meng Xu
2014-11-10 15:36 ` Dario Faggioli
2014-11-10 15:38 ` George Dunlap
2014-11-10 15:40 ` George Dunlap
2014-11-10 16:04 ` Meng Xu
2014-11-10 16:15 ` George Dunlap [this message]
2014-10-29 10:06 ` Sanity check input and " Dario Faggioli
2014-10-29 14:23 ` Meng Xu
2014-10-29 17:52 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460E49A.5020000@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mengxu@cis.upenn.edu \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.