All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
Date: Wed, 12 Nov 2014 10:56:24 +0000	[thread overview]
Message-ID: <1415789784.25176.67.camel@citrix.com> (raw)
In-Reply-To: <1415788771-16563-1-git-send-email-wei.liu2@citrix.com>

On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote:
> ... otherwise when device add operation fails, the error message looks
> like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
> device", which is not very helpful.

Thanks.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
>  tools/libxl/libxl.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index f7961f6..de23fec 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
>                                                                          \
>          GCNEW(aodev);                                                   \
>          libxl__prepare_ao_device(ao, aodev);                            \
> +        aodev->action = LIBXL__DEVICE_ACTION_ADD;                       \
>          aodev->callback = device_addrm_aocomplete;                      \
>          aodev->update_json = true;                                      \
>          libxl__device_##type##_add(egc, domid, type, aodev);            \

  parent reply	other threads:[~2014-11-12 10:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 10:39 [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD Wei Liu
2014-11-12 10:55 ` Wei Liu
2014-11-12 10:56 ` Ian Campbell [this message]
2014-11-12 15:16   ` Konrad Rzeszutek Wilk
2014-11-14 10:57     ` Ian Campbell
2014-11-14 10:35   ` Ian Campbell
2014-11-14 10:40     ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2014-11-11 13:46 Wei Liu
2014-11-12 10:01 ` Ian Campbell
2014-11-12 10:36   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415789784.25176.67.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.