Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Nov 12, 2014 at 10:56:24AM +0000, Ian Campbell wrote:
> On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote:
> > ... otherwise when device add operation fails, the error message looks
> > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
> > device", which is not very helpful.
> 
> Thanks.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > ---
> >  tools/libxl/libxl.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index f7961f6..de23fec 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> >                                                                          \
> >          GCNEW(aodev);                                                   \
> >          libxl__prepare_ao_device(ao, aodev);                            \
> > +        aodev->action = LIBXL__DEVICE_ACTION_ADD;                       \
> >          aodev->callback = device_addrm_aocomplete;                      \
> >          aodev->update_json = true;                                      \
> >          libxl__device_##type##_add(egc, domid, type, aodev);            \
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel