* [PATCH for-4.5] xl: correct test condition on libxl_domain_info
@ 2014-11-12 11:05 Wei Liu
2014-11-12 11:10 ` Ian Campbell
0 siblings, 1 reply; 7+ messages in thread
From: Wei Liu @ 2014-11-12 11:05 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu, Ian Campbell
The `if' statement considered return value 0 from libxl_domain_info an
error, while 0 actually means success.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
---
This is a bug fix for PSR feature. This feature was added recently and it's
not an regression. However, it would be good to have it working correctly
since the beginning, and the fix is straightforward, which should be of
very low risk.
---
tools/libxl/xl_cmdimpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 3c9f146..9afef3f 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -7908,7 +7908,7 @@ static int psr_cmt_show_cache_occupancy(uint32_t domid)
/* Each domain */
if (domid != INVALID_DOMID) {
libxl_dominfo dominfo;
- if (!libxl_domain_info(ctx, &dominfo, domid)) {
+ if (libxl_domain_info(ctx, &dominfo, domid)) {
fprintf(stderr, "Failed to get domain info for %d\n", domid);
return -1;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.5] xl: correct test condition on libxl_domain_info
2014-11-12 11:05 [PATCH for-4.5] xl: correct test condition on libxl_domain_info Wei Liu
@ 2014-11-12 11:10 ` Ian Campbell
2014-11-12 15:22 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2014-11-12 11:10 UTC (permalink / raw)
To: Wei Liu; +Cc: Chao Peng, Dongxiao Xu, Ian Jackson, xen-devel
CCing the folks who signed-of-by is on the original patch
On Wed, 2014-11-12 at 11:05 +0000, Wei Liu wrote:
> The `if' statement considered return value 0 from libxl_domain_info an
> error, while 0 actually means success.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
> This is a bug fix for PSR feature. This feature was added recently and it's
> not an regression. However, it would be good to have it working correctly
> since the beginning, and the fix is straightforward, which should be of
> very low risk.
Ack.
> ---
> tools/libxl/xl_cmdimpl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 3c9f146..9afef3f 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -7908,7 +7908,7 @@ static int psr_cmt_show_cache_occupancy(uint32_t domid)
> /* Each domain */
> if (domid != INVALID_DOMID) {
> libxl_dominfo dominfo;
> - if (!libxl_domain_info(ctx, &dominfo, domid)) {
> + if (libxl_domain_info(ctx, &dominfo, domid)) {
> fprintf(stderr, "Failed to get domain info for %d\n", domid);
> return -1;
> }
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.5] xl: correct test condition on libxl_domain_info
2014-11-12 11:10 ` Ian Campbell
@ 2014-11-12 15:22 ` Konrad Rzeszutek Wilk
2014-11-12 17:31 ` Wei Liu
2014-11-13 1:01 ` Chao Peng
0 siblings, 2 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-11-12 15:22 UTC (permalink / raw)
To: Ian Campbell; +Cc: Chao Peng, Dongxiao Xu, Wei Liu, Ian Jackson, xen-devel
On Wed, Nov 12, 2014 at 11:10:52AM +0000, Ian Campbell wrote:
> CCing the folks who signed-of-by is on the original patch
>
> On Wed, 2014-11-12 at 11:05 +0000, Wei Liu wrote:
> > The `if' statement considered return value 0 from libxl_domain_info an
> > error, while 0 actually means success.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > ---
> > This is a bug fix for PSR feature. This feature was added recently and it's
> > not an regression. However, it would be good to have it working correctly
> > since the beginning, and the fix is straightforward, which should be of
> > very low risk.
>
> Ack.
I concur and I think it should go in Xen 4.5, but I would like their
input first.
>
> > ---
> > tools/libxl/xl_cmdimpl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > index 3c9f146..9afef3f 100644
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -7908,7 +7908,7 @@ static int psr_cmt_show_cache_occupancy(uint32_t domid)
> > /* Each domain */
> > if (domid != INVALID_DOMID) {
> > libxl_dominfo dominfo;
> > - if (!libxl_domain_info(ctx, &dominfo, domid)) {
> > + if (libxl_domain_info(ctx, &dominfo, domid)) {
> > fprintf(stderr, "Failed to get domain info for %d\n", domid);
> > return -1;
> > }
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.5] xl: correct test condition on libxl_domain_info
2014-11-12 15:22 ` Konrad Rzeszutek Wilk
@ 2014-11-12 17:31 ` Wei Liu
2014-11-13 1:01 ` Chao Peng
1 sibling, 0 replies; 7+ messages in thread
From: Wei Liu @ 2014-11-12 17:31 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Wei Liu, Ian Campbell, Ian Jackson, xen-devel, Dongxiao Xu,
Chao Peng
On Wed, Nov 12, 2014 at 10:22:07AM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 12, 2014 at 11:10:52AM +0000, Ian Campbell wrote:
> > CCing the folks who signed-of-by is on the original patch
> >
> > On Wed, 2014-11-12 at 11:05 +0000, Wei Liu wrote:
> > > The `if' statement considered return value 0 from libxl_domain_info an
> > > error, while 0 actually means success.
> > >
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > ---
> > > This is a bug fix for PSR feature. This feature was added recently and it's
> > > not an regression. However, it would be good to have it working correctly
> > > since the beginning, and the fix is straightforward, which should be of
> > > very low risk.
> >
> > Ack.
>
> I concur and I think it should go in Xen 4.5, but I would like their
> input first.
>
Dude, you're so cautious! ;-)
> >
> > > ---
> > > tools/libxl/xl_cmdimpl.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > > index 3c9f146..9afef3f 100644
> > > --- a/tools/libxl/xl_cmdimpl.c
> > > +++ b/tools/libxl/xl_cmdimpl.c
> > > @@ -7908,7 +7908,7 @@ static int psr_cmt_show_cache_occupancy(uint32_t domid)
> > > /* Each domain */
> > > if (domid != INVALID_DOMID) {
> > > libxl_dominfo dominfo;
> > > - if (!libxl_domain_info(ctx, &dominfo, domid)) {
> > > + if (libxl_domain_info(ctx, &dominfo, domid)) {
> > > fprintf(stderr, "Failed to get domain info for %d\n", domid);
> > > return -1;
> > > }
> >
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.5] xl: correct test condition on libxl_domain_info
2014-11-12 15:22 ` Konrad Rzeszutek Wilk
2014-11-12 17:31 ` Wei Liu
@ 2014-11-13 1:01 ` Chao Peng
2014-11-13 1:08 ` Konrad Rzeszutek Wilk
1 sibling, 1 reply; 7+ messages in thread
From: Chao Peng @ 2014-11-13 1:01 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Ian Jackson, Dongxiao Xu, Wei Liu, Ian Campbell, xen-devel
On Wed, Nov 12, 2014 at 10:22:07AM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 12, 2014 at 11:10:52AM +0000, Ian Campbell wrote:
> > CCing the folks who signed-of-by is on the original patch
> >
> > On Wed, 2014-11-12 at 11:05 +0000, Wei Liu wrote:
> > > The `if' statement considered return value 0 from libxl_domain_info an
> > > error, while 0 actually means success.
> > >
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > ---
> > > This is a bug fix for PSR feature. This feature was added recently and it's
> > > not an regression. However, it would be good to have it working correctly
> > > since the beginning, and the fix is straightforward, which should be of
> > > very low risk.
> >
> > Ack.
>
> I concur and I think it should go in Xen 4.5, but I would like their
> input first.
Yeah, I'd like it to go in.
Thanks Wei for your quick fix.
Chao
>
> >
> > > ---
> > > tools/libxl/xl_cmdimpl.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > > index 3c9f146..9afef3f 100644
> > > --- a/tools/libxl/xl_cmdimpl.c
> > > +++ b/tools/libxl/xl_cmdimpl.c
> > > @@ -7908,7 +7908,7 @@ static int psr_cmt_show_cache_occupancy(uint32_t domid)
> > > /* Each domain */
> > > if (domid != INVALID_DOMID) {
> > > libxl_dominfo dominfo;
> > > - if (!libxl_domain_info(ctx, &dominfo, domid)) {
> > > + if (libxl_domain_info(ctx, &dominfo, domid)) {
> > > fprintf(stderr, "Failed to get domain info for %d\n", domid);
> > > return -1;
> > > }
> >
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.5] xl: correct test condition on libxl_domain_info
2014-11-13 1:01 ` Chao Peng
@ 2014-11-13 1:08 ` Konrad Rzeszutek Wilk
2014-11-14 10:35 ` Ian Campbell
0 siblings, 1 reply; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-11-13 1:08 UTC (permalink / raw)
To: Chao Peng; +Cc: Ian Jackson, Dongxiao Xu, Wei Liu, Ian Campbell, xen-devel
On November 12, 2014 8:01:21 PM EST, Chao Peng <chao.p.peng@linux.intel.com> wrote:
>On Wed, Nov 12, 2014 at 10:22:07AM -0500, Konrad Rzeszutek Wilk wrote:
>> On Wed, Nov 12, 2014 at 11:10:52AM +0000, Ian Campbell wrote:
>> > CCing the folks who signed-of-by is on the original patch
>> >
>> > On Wed, 2014-11-12 at 11:05 +0000, Wei Liu wrote:
>> > > The `if' statement considered return value 0 from
>libxl_domain_info an
>> > > error, while 0 actually means success.
>> > >
>> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>> >
>> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
>> >
>> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>> > > ---
>> > > This is a bug fix for PSR feature. This feature was added
>recently and it's
>> > > not an regression. However, it would be good to have it working
>correctly
>> > > since the beginning, and the fix is straightforward, which should
>be of
>> > > very low risk.
>> >
>> > Ack.
>>
>> I concur and I think it should go in Xen 4.5, but I would like their
>> input first.
>
>Yeah, I'd like it to go in.
>Thanks Wei for your quick fix.
Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
>Chao
>>
>> >
>> > > ---
>> > > tools/libxl/xl_cmdimpl.c | 2 +-
>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
>> > > index 3c9f146..9afef3f 100644
>> > > --- a/tools/libxl/xl_cmdimpl.c
>> > > +++ b/tools/libxl/xl_cmdimpl.c
>> > > @@ -7908,7 +7908,7 @@ static int
>psr_cmt_show_cache_occupancy(uint32_t domid)
>> > > /* Each domain */
>> > > if (domid != INVALID_DOMID) {
>> > > libxl_dominfo dominfo;
>> > > - if (!libxl_domain_info(ctx, &dominfo, domid)) {
>> > > + if (libxl_domain_info(ctx, &dominfo, domid)) {
>> > > fprintf(stderr, "Failed to get domain info for
>%d\n", domid);
>> > > return -1;
>> > > }
>> >
>> >
>> >
>> > _______________________________________________
>> > Xen-devel mailing list
>> > Xen-devel@lists.xen.org
>> > http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.5] xl: correct test condition on libxl_domain_info
2014-11-13 1:08 ` Konrad Rzeszutek Wilk
@ 2014-11-14 10:35 ` Ian Campbell
0 siblings, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2014-11-14 10:35 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Chao Peng, Dongxiao Xu, Wei Liu, Ian Jackson, xen-devel
On Wed, 2014-11-12 at 20:08 -0500, Konrad Rzeszutek Wilk wrote:
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-11-14 10:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 11:05 [PATCH for-4.5] xl: correct test condition on libxl_domain_info Wei Liu
2014-11-12 11:10 ` Ian Campbell
2014-11-12 15:22 ` Konrad Rzeszutek Wilk
2014-11-12 17:31 ` Wei Liu
2014-11-13 1:01 ` Chao Peng
2014-11-13 1:08 ` Konrad Rzeszutek Wilk
2014-11-14 10:35 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.