From: Ian Campbell <Ian.Campbell@citrix.com>
To: Clark Laughlin <clark.laughlin@linaro.org>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] mkdeb previously set the package architecture to be 'amd64' for anything other than XEN_TARGET_ARCH=x86_32. This patch attempts to correctly map the architecture from GNU names to debian names for x86 and ARM architectures, or otherwise, defaults it to the value in XEN_TARGET_ARCH.
Date: Wed, 12 Nov 2014 15:30:09 +0000 [thread overview]
Message-ID: <1415806209.1155.19.camel@citrix.com> (raw)
In-Reply-To: <1415806043-28199-1-git-send-email-clark.laughlin@linaro.org>
On Wed, 2014-11-12 at 09:27 -0600, Clark Laughlin wrote:
> Signed-off-by: Clark Laughlin <clark.laughlin@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
The mapping is a bit more zealous that strictly needed:
> +# map the architecture, if necessary
> +arch=$XEN_TARGET_ARCH
> +case "$XEN_TARGET_ARCH" in
> + x86_32) arch=i386 ;;
> + i686) arch=i386 ;;
> + x86_64) arch=amd64 ;;
> + arm32) arch=armhf ;;
> + aarch64) arch=arm64 ;;
> +esac
I don't think $XEN_TARGET_ARCH can ever be i686 or aarch64, that would
break all over the place I think. Not that there is any harm in handling
those cases.
Ian.
prev parent reply other threads:[~2014-11-12 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 15:27 [PATCH] mkdeb previously set the package architecture to be 'amd64' for anything other than XEN_TARGET_ARCH=x86_32. This patch attempts to correctly map the architecture from GNU names to debian names for x86 and ARM architectures, or otherwise, defaults it to the value in XEN_TARGET_ARCH Clark Laughlin
2014-11-12 15:30 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415806209.1155.19.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=clark.laughlin@linaro.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.