From: Ian Campbell <Ian.Campbell@citrix.com>
To: Clark Laughlin <clark.laughlin@linaro.org>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] mkdeb: correctly map package architectures for x86 and ARM
Date: Wed, 12 Nov 2014 15:43:46 +0000 [thread overview]
Message-ID: <1415807026.1155.21.camel@citrix.com> (raw)
In-Reply-To: <1415806728-28484-1-git-send-email-clark.laughlin@linaro.org>
On Wed, 2014-11-12 at 09:38 -0600, Clark Laughlin wrote:
> mkdeb previously set the package architecture to be 'amd64' for anything other than
> XEN_TARGET_ARCH=x86_32. This patch attempts to correctly map the architecture from
> GNU names to debian names for x86 and ARM architectures, or otherwise, defaults it
> to the value in XEN_TARGET_ARCH.
>
> Signed-off-by: Clark Laughlin <clark.laughlin@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> Changed since v1: corrected commit message / subject
> ---
> tools/misc/mkdeb | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/tools/misc/mkdeb b/tools/misc/mkdeb
> index 3bbf881..4d14d9e 100644
> --- a/tools/misc/mkdeb
> +++ b/tools/misc/mkdeb
> @@ -13,11 +13,16 @@ fi
>
> cd $1
> version=$2
> -if test "$XEN_TARGET_ARCH" = "x86_32"; then
> - arch=i386
> -else
> - arch=amd64
> -fi
> +
> +# map the architecture, if necessary
> +arch=$XEN_TARGET_ARCH
> +case "$XEN_TARGET_ARCH" in
> + x86_32) arch=i386 ;;
> + i686) arch=i386 ;;
> + x86_64) arch=amd64 ;;
> + arm32) arch=armhf ;;
> + aarch64) arch=arm64 ;;
> +esac
>
> # Prepare the directory to package
> cd dist
next prev parent reply other threads:[~2014-11-12 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 15:38 [PATCH v2] mkdeb: correctly map package architectures for x86 and ARM Clark Laughlin
2014-11-12 15:43 ` Ian Campbell [this message]
2014-11-14 10:10 ` Ian Campbell
2014-11-19 19:45 ` Konrad Rzeszutek Wilk
2014-11-20 15:58 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415807026.1155.21.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=clark.laughlin@linaro.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.