From: Ian Campbell <Ian.Campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Clark Laughlin <clark.laughlin@linaro.org>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] mkdeb: correctly map package architectures for x86 and ARM
Date: Thu, 20 Nov 2014 15:58:07 +0000 [thread overview]
Message-ID: <1416499087.14429.35.camel@citrix.com> (raw)
In-Reply-To: <20141119194515.GB18117@laptop.dumpdata.com>
On Wed, 2014-11-19 at 14:45 -0500, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 14, 2014 at 10:10:58AM +0000, Ian Campbell wrote:
> > (CCing some more maintainers and the release manager)
> >
> > On Wed, 2014-11-12 at 15:43 +0000, Ian Campbell wrote:
> > > On Wed, 2014-11-12 at 09:38 -0600, Clark Laughlin wrote:
> > > > mkdeb previously set the package architecture to be 'amd64' for anything other than
> > > > XEN_TARGET_ARCH=x86_32. This patch attempts to correctly map the architecture from
> > > > GNU names to debian names for x86 and ARM architectures, or otherwise, defaults it
> > > > to the value in XEN_TARGET_ARCH.
> > > >
> > > > Signed-off-by: Clark Laughlin <clark.laughlin@linaro.org>
> > >
> > > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > Actually thinking about it some more I'd be happier arguing for a freeze
> > exception for something like the below which only handles the actual
> > valid values of XEN_TARGET_ARCH and not the GNU names (which cannot
> > happen) and prints an error for unknown architectures (so new ports
> > aren't bitten in the future, etc).
> >
> > Konrad, wrt the freeze I think this is low risk for breaking x86
> > platforms and makes things work for arm, so is worth it.
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Ian J acked on IRC, so I've applied, thanks.
prev parent reply other threads:[~2014-11-20 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 15:38 [PATCH v2] mkdeb: correctly map package architectures for x86 and ARM Clark Laughlin
2014-11-12 15:43 ` Ian Campbell
2014-11-14 10:10 ` Ian Campbell
2014-11-19 19:45 ` Konrad Rzeszutek Wilk
2014-11-20 15:58 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416499087.14429.35.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=clark.laughlin@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.