From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 1/2] target_editfile: Improve doc comment
Date: Fri, 14 Nov 2014 16:28:49 +0000 [thread overview]
Message-ID: <1415982529.7113.23.camel@citrix.com> (raw)
In-Reply-To: <1415982424-7007-1-git-send-email-ian.jackson@eu.citrix.com>
On Fri, 2014-11-14 at 16:27 +0000, Ian Jackson wrote:
> More clearly state which arguments are optional.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> Osstest/TestSupport.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index 45ceee9..46b6720 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -521,7 +521,8 @@ sub teditfileex {
> sub target_editfile_root ($$$;$$) { teditfileex('root',@_); }
> sub target_editfile ($$$;$$) { teditfileex('osstest',@_); }
> # my $code= pop @_;
> - # my ($ho,$rfile,$lleaf,$rdest) = @_;
> + # my ($ho,$rfile, $lleaf,$rdest) = @_;
> + # ^^^^^^^^^^^^^ optional
>
> sub target_cmd_build ($$$$) {
> my ($ho,$timeout,$builddir,$script) = @_;
prev parent reply other threads:[~2014-11-14 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 16:27 [OSSTEST PATCH 1/2] target_editfile: Improve doc comment Ian Jackson
2014-11-14 16:27 ` [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes Ian Jackson
2014-11-14 16:29 ` Ian Campbell
2014-11-14 16:28 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415982529.7113.23.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.