* [OSSTEST PATCH 1/2] target_editfile: Improve doc comment
@ 2014-11-14 16:27 Ian Jackson
2014-11-14 16:27 ` [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes Ian Jackson
2014-11-14 16:28 ` [OSSTEST PATCH 1/2] target_editfile: Improve doc comment Ian Campbell
0 siblings, 2 replies; 4+ messages in thread
From: Ian Jackson @ 2014-11-14 16:27 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Ian Campbell
More clearly state which arguments are optional.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
Osstest/TestSupport.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 45ceee9..46b6720 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -521,7 +521,8 @@ sub teditfileex {
sub target_editfile_root ($$$;$$) { teditfileex('root',@_); }
sub target_editfile ($$$;$$) { teditfileex('osstest',@_); }
# my $code= pop @_;
- # my ($ho,$rfile,$lleaf,$rdest) = @_;
+ # my ($ho,$rfile, $lleaf,$rdest) = @_;
+ # ^^^^^^^^^^^^^ optional
sub target_cmd_build ($$$$) {
my ($ho,$timeout,$builddir,$script) = @_;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes
2014-11-14 16:27 [OSSTEST PATCH 1/2] target_editfile: Improve doc comment Ian Jackson
@ 2014-11-14 16:27 ` Ian Jackson
2014-11-14 16:29 ` Ian Campbell
2014-11-14 16:28 ` [OSSTEST PATCH 1/2] target_editfile: Improve doc comment Ian Campbell
1 sibling, 1 reply; 4+ messages in thread
From: Ian Jackson @ 2014-11-14 16:27 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Ian Campbell
With -v, runvar-perlop would unconditionally print a message about the
changed variable. Instead, only call runvar_set if the value is to
change.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
cs-adjust-flight | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cs-adjust-flight b/cs-adjust-flight
index 7ec17e3..d6cab1a 100755
--- a/cs-adjust-flight
+++ b/cs-adjust-flight
@@ -268,7 +268,8 @@ sub change__runvar_perlop {
my ($job, $name, $varrow) = @_;
my $oldval = $varrow->{val};
my $newval = perlop_value($job, $name, $op, $oldval);
- runvar_set($job, $name, $newval, " (modified from \`$oldval')");
+ runvar_set($job, $name, $newval, " (modified from \`$oldval')")
+ if $newval ne $oldval;
}, 'IGNORE');
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes
2014-11-14 16:27 ` [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes Ian Jackson
@ 2014-11-14 16:29 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2014-11-14 16:29 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Fri, 2014-11-14 at 16:27 +0000, Ian Jackson wrote:
> With -v, runvar-perlop would unconditionally print a message about the
> changed variable. Instead, only call runvar_set if the value is to
> change.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> cs-adjust-flight | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cs-adjust-flight b/cs-adjust-flight
> index 7ec17e3..d6cab1a 100755
> --- a/cs-adjust-flight
> +++ b/cs-adjust-flight
> @@ -268,7 +268,8 @@ sub change__runvar_perlop {
> my ($job, $name, $varrow) = @_;
> my $oldval = $varrow->{val};
> my $newval = perlop_value($job, $name, $op, $oldval);
> - runvar_set($job, $name, $newval, " (modified from \`$oldval')");
> + runvar_set($job, $name, $newval, " (modified from \`$oldval')")
> + if $newval ne $oldval;
> }, 'IGNORE');
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OSSTEST PATCH 1/2] target_editfile: Improve doc comment
2014-11-14 16:27 [OSSTEST PATCH 1/2] target_editfile: Improve doc comment Ian Jackson
2014-11-14 16:27 ` [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes Ian Jackson
@ 2014-11-14 16:28 ` Ian Campbell
1 sibling, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2014-11-14 16:28 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Fri, 2014-11-14 at 16:27 +0000, Ian Jackson wrote:
> More clearly state which arguments are optional.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> Osstest/TestSupport.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index 45ceee9..46b6720 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -521,7 +521,8 @@ sub teditfileex {
> sub target_editfile_root ($$$;$$) { teditfileex('root',@_); }
> sub target_editfile ($$$;$$) { teditfileex('osstest',@_); }
> # my $code= pop @_;
> - # my ($ho,$rfile,$lleaf,$rdest) = @_;
> + # my ($ho,$rfile, $lleaf,$rdest) = @_;
> + # ^^^^^^^^^^^^^ optional
>
> sub target_cmd_build ($$$$) {
> my ($ho,$timeout,$builddir,$script) = @_;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-14 16:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-14 16:27 [OSSTEST PATCH 1/2] target_editfile: Improve doc comment Ian Jackson
2014-11-14 16:27 ` [OSSTEST PATCH 2/2] cs-adjust-flight: runvar-perlop: Do not report non-changes Ian Jackson
2014-11-14 16:29 ` Ian Campbell
2014-11-14 16:28 ` [OSSTEST PATCH 1/2] target_editfile: Improve doc comment Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.