From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, Chunyan Liu <cyliu@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] fix rename: xenstore not fully updated
Date: Mon, 17 Nov 2014 10:58:46 +0000 [thread overview]
Message-ID: <1416221926.27385.25.camel@citrix.com> (raw)
In-Reply-To: <1416220965.27385.23.camel@citrix.com>
On Mon, 2014-11-17 at 10:42 +0000, Ian Campbell wrote:
> On Mon, 2014-11-17 at 10:41 +0000, Wei Liu wrote:
> > On Mon, Nov 17, 2014 at 10:25:31AM +0000, Ian Campbell wrote:
> > > On Mon, 2014-11-17 at 09:52 +0000, Wei Liu wrote:
> > > > > + /* update backend /local/domain/0/backend/<device>/<domid>/.../domain */
> > > > > + be_dev = libxl__xs_directory(gc, trans, "/local/domain/0/backend", &ndevs);
> > > >
> > > > The hard-coded 0 cannot work if you have driver domain.
> > > >
> > > > At the very least it should be using LIBXL_TOOLSTACK_DOMID.
> > >
> > > Does anyone know the purpose of this node, i.e. what consumes it?
> > > docs/misc/xenstore-paths.markdown doesn't mention it, neither do any of
> > > xen/include/public/io/*.h AFAICS.
> > >
> > > The backend needing to know the name (as opposed to domid) of the
> > > frontend domain seems rather unusual to me.
> > >
> >
> > I think it's for consistency but Chunyan might have different opinions.
>
> Consistency of what?
Dunno if this is relevant but I appear to have this node only for pci
and console backend directories, and not for vbd or vif.
I quick grep for domain\" in both linux/drivers/xen/xen-pciback and
xen/tools/console seems to suggest neither of them are reading it.
Ian
next prev parent reply other threads:[~2014-11-17 10:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 9:19 [PATCH] fix rename: xenstore not fully updated Chunyan Liu
2014-11-17 9:52 ` Wei Liu
2014-11-17 10:25 ` Ian Campbell
2014-11-17 10:41 ` Wei Liu
2014-11-17 10:42 ` Ian Campbell
2014-11-17 10:48 ` Wei Liu
2014-11-17 10:59 ` Ian Campbell
2014-11-17 10:58 ` Ian Campbell [this message]
2014-11-17 15:45 ` Ian Jackson
2014-11-17 15:53 ` Ian Campbell
2014-11-18 1:39 ` Chun Yan Liu
2014-11-18 2:13 ` Chun Yan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416221926.27385.25.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=cyliu@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.