All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: wei.liu2@citrix.com, Chunyan Liu <cyliu@suse.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] fix rename: xenstore not fully updated
Date: Mon, 17 Nov 2014 15:53:14 +0000	[thread overview]
Message-ID: <1416239594.5466.23.camel@citrix.com> (raw)
In-Reply-To: <21610.6141.943750.141913@mariner.uk.xensource.com>

On Mon, 2014-11-17 at 15:45 +0000, Ian Jackson wrote:
> > +    /* update backend /local/domain/0/backend/<device>/<domid>/.../domain */
> 
> Um, what on earth creates that ?
> 
> Worse, what reads it ?
> 
> I think that putting this information in the backend directory is
> entirely wrong.

I concluded the same thing.

Chunyan, I think it would be better to simply remove the code which adds
this domain field under the backend dir in the first place, instead of
adding all this complex code to try and keep it up to date.

Can you do that in the next iteration please?

Thanks,

Ian.

  reply	other threads:[~2014-11-17 15:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17  9:19 [PATCH] fix rename: xenstore not fully updated Chunyan Liu
2014-11-17  9:52 ` Wei Liu
2014-11-17 10:25   ` Ian Campbell
2014-11-17 10:41     ` Wei Liu
2014-11-17 10:42       ` Ian Campbell
2014-11-17 10:48         ` Wei Liu
2014-11-17 10:59           ` Ian Campbell
2014-11-17 10:58         ` Ian Campbell
2014-11-17 15:45 ` Ian Jackson
2014-11-17 15:53   ` Ian Campbell [this message]
2014-11-18  1:39     ` Chun Yan Liu
2014-11-18  2:13   ` Chun Yan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416239594.5466.23.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=cyliu@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.