All of lore.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Steven Stewart-Gallus <sstewartgallus00@mylangara.bc.ca>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"J. Bruce Fields" <bfields@redhat.com>,
	Doug Ledford <dledford@redhat.com>,
	linux-newbie@vger.kernel.org
Subject: Re: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks
Date: Mon, 17 Nov 2014 12:52:10 -0800	[thread overview]
Message-ID: <1416257530.4494.0.camel@localhost> (raw)
In-Reply-To: <546A47C6.4030309@colorfullife.com>

On Mon, 2014-11-17 at 20:08 +0100, Manfred Spraul wrote:
> Hi Steven,
> 
> On 11/16/2014 08:40 PM, Steven Stewart-Gallus wrote:
> > Finally, please don't ignore the rest of my message. Even if my patch
> > isn't that good there are lots of ways to compromise and improve it
> > such as adding tests, annotations and making it clearer.
> 
> I think you were already given ideas how to improve the patch:
> 
> a) split the patch.
> 
> b) create test cases so that you are able to check that the code still 
> behaves as it did before

Adding/improving ipc kselftests would also be very welcome.

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

WARNING: multiple messages have this Message-ID (diff)
From: Davidlohr Bueso <dave@stgolabs.net>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Steven Stewart-Gallus <sstewartgallus00@mylangara.bc.ca>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"J. Bruce Fields" <bfields@redhat.com>,
	Doug Ledford <dledford@redhat.com>,
	linux-newbie@vger.kernel.org
Subject: Re: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks
Date: Mon, 17 Nov 2014 12:52:10 -0800	[thread overview]
Message-ID: <1416257530.4494.0.camel@localhost> (raw)
In-Reply-To: <546A47C6.4030309@colorfullife.com>

On Mon, 2014-11-17 at 20:08 +0100, Manfred Spraul wrote:
> Hi Steven,
> 
> On 11/16/2014 08:40 PM, Steven Stewart-Gallus wrote:
> > Finally, please don't ignore the rest of my message. Even if my patch
> > isn't that good there are lots of ways to compromise and improve it
> > such as adding tests, annotations and making it clearer.
> 
> I think you were already given ideas how to improve the patch:
> 
> a) split the patch.
> 
> b) create test cases so that you are able to check that the code still 
> behaves as it did before

Adding/improving ipc kselftests would also be very welcome.

Thanks,
Davidlohr


  reply	other threads:[~2014-11-17 20:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07  5:40 [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks Steven Stewart-Gallus
2014-11-12  0:21 ` Andrew Morton
2014-11-15  4:42   ` Steven Stewart-Gallus
2014-11-12  8:16 ` Davidlohr Bueso
2014-11-15  4:44   ` Steven Stewart-Gallus
2014-11-15 21:22     ` Davidlohr Bueso
2014-11-16 19:40       ` Steven Stewart-Gallus
2014-11-16 19:40         ` Steven Stewart-Gallus
2014-11-17 19:08         ` Manfred Spraul
2014-11-17 19:08           ` Manfred Spraul
2014-11-17 20:52           ` Davidlohr Bueso [this message]
2014-11-17 20:52             ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416257530.4494.0.camel@localhost \
    --to=dave@stgolabs.net \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@redhat.com \
    --cc=dledford@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-newbie@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=sstewartgallus00@mylangara.bc.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.