From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] of/address: Don't throw errors on absent ranges properties
Date: Wed, 19 Nov 2014 13:32:31 +1100 [thread overview]
Message-ID: <1416364351.5704.22.camel@kernel.crashing.org> (raw)
In-Reply-To: <20141118165739.7382AC40966-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
On Tue, 2014-11-18 at 16:57 +0000, Grant Likely wrote:
> On Fri, 14 Nov 2014 17:58:23 +1100
> , Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
> wrote:
> > The core always tries to translate any "reg" property to construct the platform
> > device names. This results in a pile of "OF: no ranges; cannot translate" errors
> > in dmesg whenever we expose things like i2c devices that cannot directly translate
> > to the MMIO space.
>
> I don't have a problem with the change, but it seems to be catching an
> odd usage of of_device_make_bus_id(). Why is of_device_make_bus_id()
> being called on i2c devices? Those shouldn't be modelled as
> platform_devices.
Sorry, this was my explanation being full of crap. It's my i2c
_controller_ which is a platform device, and is on the xscom bus which
isn't directly MMIO translatable.
The patch still stands :)
Cheers,
Ben.
> g.
>
> >
> > Turn this into a pr_debug instead
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
> >
> > diff --git a/drivers/of/address.c b/drivers/of/address.c
> > index f0541fd..bf1f79d 100644
> > --- a/drivers/of/address.c
> > +++ b/drivers/of/address.c
> > @@ -444,7 +444,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
> > */
> > ranges = of_get_property(parent, rprop, &rlen);
> > if (ranges == NULL && !of_empty_ranges_quirk()) {
> > - pr_err("OF: no ranges; cannot translate\n");
> > + pr_debug("OF: no ranges; cannot translate\n");
> > return 1;
> > }
> > if (ranges == NULL || rlen == 0) {
> >
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <robherring2@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of/address: Don't throw errors on absent ranges properties
Date: Wed, 19 Nov 2014 13:32:31 +1100 [thread overview]
Message-ID: <1416364351.5704.22.camel@kernel.crashing.org> (raw)
In-Reply-To: <20141118165739.7382AC40966@trevor.secretlab.ca>
On Tue, 2014-11-18 at 16:57 +0000, Grant Likely wrote:
> On Fri, 14 Nov 2014 17:58:23 +1100
> , Benjamin Herrenschmidt <benh@kernel.crashing.org>
> wrote:
> > The core always tries to translate any "reg" property to construct the platform
> > device names. This results in a pile of "OF: no ranges; cannot translate" errors
> > in dmesg whenever we expose things like i2c devices that cannot directly translate
> > to the MMIO space.
>
> I don't have a problem with the change, but it seems to be catching an
> odd usage of of_device_make_bus_id(). Why is of_device_make_bus_id()
> being called on i2c devices? Those shouldn't be modelled as
> platform_devices.
Sorry, this was my explanation being full of crap. It's my i2c
_controller_ which is a platform device, and is on the xscom bus which
isn't directly MMIO translatable.
The patch still stands :)
Cheers,
Ben.
> g.
>
> >
> > Turn this into a pr_debug instead
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >
> > diff --git a/drivers/of/address.c b/drivers/of/address.c
> > index f0541fd..bf1f79d 100644
> > --- a/drivers/of/address.c
> > +++ b/drivers/of/address.c
> > @@ -444,7 +444,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
> > */
> > ranges = of_get_property(parent, rprop, &rlen);
> > if (ranges == NULL && !of_empty_ranges_quirk()) {
> > - pr_err("OF: no ranges; cannot translate\n");
> > + pr_debug("OF: no ranges; cannot translate\n");
> > return 1;
> > }
> > if (ranges == NULL || rlen == 0) {
> >
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-11-19 2:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 6:58 [PATCH] of/address: Don't throw errors on absent ranges properties Benjamin Herrenschmidt
2014-11-14 6:58 ` Benjamin Herrenschmidt
2014-11-18 16:57 ` Grant Likely
[not found] ` <20141118165739.7382AC40966-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-19 2:32 ` Benjamin Herrenschmidt [this message]
2014-11-19 2:32 ` Benjamin Herrenschmidt
2014-11-19 10:31 ` Grant Likely
[not found] ` <20141119103140.2B9F4C40551-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-20 23:07 ` Benjamin Herrenschmidt
2014-11-20 23:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416364351.5704.22.camel@kernel.crashing.org \
--to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.