[PATCH] device coredump: fix minor issue in Kconfig file

[PATCH] device coredump: fix minor issue in Kconfig file

[Amitkumar Karwar]

if "CONFIG_DEV_COREDUMP=y" is added to configuration file, it
gets removed when final configuration file is generated. The
reason is it requires CONFIG_WANT_DEV_COREDUMP to be enabled.

Currently "make menuconfig" doesn't display an option to enable
WANT_DEV_COREDUMP. This patch updates Kconfig so that user can
enable WANT_DEV_COREDUMP.

Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Xinming Hu <huxm@marvell.com>
Tested-by: Xinming Hu <huxm@marvell.com>
---
 drivers/base/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 61a33f4..e491b07 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -166,7 +166,7 @@ config FW_LOADER_USER_HELPER_FALLBACK
 	  If you are unsure about this, say N here.
 
 config WANT_DEV_COREDUMP
-	bool
+	bool "Want device coredump"
 	help
 	  Drivers should "select" this option if they desire to use the
 	  device coredump mechanism.
-- 
1.8.1.4

[PATCH] device coredump: fix minor issue in Kconfig file

[Amitkumar Karwar]

if "CONFIG_DEV_COREDUMP=y" is added to configuration file, it
gets removed when final configuration file is generated. The
reason is it requires CONFIG_WANT_DEV_COREDUMP to be enabled.

Currently "make menuconfig" doesn't display an option to enable
WANT_DEV_COREDUMP. This patch updates Kconfig so that user can
enable WANT_DEV_COREDUMP.

Signed-off-by: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Xinming Hu <huxm-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Tested-by: Xinming Hu <huxm-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
---
 drivers/base/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 61a33f4..e491b07 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -166,7 +166,7 @@ config FW_LOADER_USER_HELPER_FALLBACK
 	  If you are unsure about this, say N here.
 
 config WANT_DEV_COREDUMP
-	bool
+	bool "Want device coredump"
 	help
 	  Drivers should "select" this option if they desire to use the
 	  device coredump mechanism.
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] device coredump: fix minor issue in Kconfig file

[Johannes Berg]

On Wed, 2014-11-19 at 05:28 -0800, Amitkumar Karwar wrote:
> if "CONFIG_DEV_COREDUMP=y" is added to configuration file, it
> gets removed when final configuration file is generated. The
> reason is it requires CONFIG_WANT_DEV_COREDUMP to be enabled.
> 
> Currently "make menuconfig" doesn't display an option to enable
> WANT_DEV_COREDUMP. This patch updates Kconfig so that user can
> enable WANT_DEV_COREDUMP.

This is completely intentional - drivers should "select
WANT_DEV_COREDUMP" and users are only able to set "ALLOW_DEV_COREDUMP=n"
to prevent it.

johannes

Re: [PATCH] device coredump: fix minor issue in Kconfig file

[Johannes Berg]

On Wed, 2014-11-19 at 05:28 -0800, Amitkumar Karwar wrote:
> if "CONFIG_DEV_COREDUMP=y" is added to configuration file, it
> gets removed when final configuration file is generated. The
> reason is it requires CONFIG_WANT_DEV_COREDUMP to be enabled.
> 
> Currently "make menuconfig" doesn't display an option to enable
> WANT_DEV_COREDUMP. This patch updates Kconfig so that user can
> enable WANT_DEV_COREDUMP.

This is completely intentional - drivers should "select
WANT_DEV_COREDUMP" and users are only able to set "ALLOW_DEV_COREDUMP=n"
to prevent it.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] device coredump: fix minor issue in Kconfig file

[Amitkumar Karwar]

SGkgSm9oYW5uZXMsDQoNCj4+IEN1cnJlbnRseSAibWFrZSBtZW51Y29uZmlnIiBkb2Vzbid0IGRp
c3BsYXkgYW4gb3B0aW9uIHRvIGVuYWJsZQ0KPj4gV0FOVF9ERVZfQ09SRURVTVAuIFRoaXMgcGF0
Y2ggdXBkYXRlcyBLY29uZmlnIHNvIHRoYXQgdXNlciBjYW4gZW5hYmxlDQo+PiBXQU5UX0RFVl9D
T1JFRFVNUC4NCj4NCj5UaGlzIGlzIGNvbXBsZXRlbHkgaW50ZW50aW9uYWwgLSBkcml2ZXJzIHNo
b3VsZCAic2VsZWN0DQo+V0FOVF9ERVZfQ09SRURVTVAiIGFuZCB1c2VycyBhcmUgb25seSBhYmxl
IHRvIHNldCAiQUxMT1dfREVWX0NPUkVEVU1QPW4iDQo+dG8gcHJldmVudCBpdC4NCj4NCg0KVGhh
bmtzIGZvciB0aGUgY2xhcmlmaWNhdGlvbi4gV2Ugd2lsbCBtb2RpZnkgb3VyIGJ0bXJ2bCBkcml2
ZXIgcGF0Y2ggYWNjb3JkaW5nbHkgdGhlbi4NCg0KUmVnYXJkcywNCkFtaXRrdW1hcg0KDQo=

RE: [PATCH] device coredump: fix minor issue in Kconfig file

[Amitkumar Karwar]

Hi Johannes,

>> Currently "make menuconfig" doesn't display an option to enable
>> WANT_DEV_COREDUMP. This patch updates Kconfig so that user can enable
>> WANT_DEV_COREDUMP.
>
>This is completely intentional - drivers should "select
>WANT_DEV_COREDUMP" and users are only able to set "ALLOW_DEV_COREDUMP=n"
>to prevent it.
>

Thanks for the clarification. We will modify our btmrvl driver patch accordingly then.

Regards,
Amitkumar